* Re: [Emacs-diffs] emacs-25 4d8fd9c 4/4: Handle "empty line" regexp in xref searches [not found] ` <E1axjKS-0002c8-KC@vcs.savannah.gnu.org> @ 2016-05-03 23:08 ` John Wiegley 2016-05-03 23:18 ` Dmitry Gutov 0 siblings, 1 reply; 3+ messages in thread From: John Wiegley @ 2016-05-03 23:08 UTC (permalink / raw) To: emacs-devel; +Cc: Eli Zaretskii, Dmitry Gutov >>>>> Dmitry Gutov <dgutov@yandex.ru> writes: > branch: emacs-25 > commit 4d8fd9cf338cf9b5dfc613657adfeabff2d9c14e > Author: Dmitry Gutov <dgutov@yandex.ru> > Commit: Dmitry Gutov <dgutov@yandex.ru> > * lisp/progmodes/xref.el (xref--collect-matches-1): Stop after one > match if re-search-forward doesn't move point (bug#23426). Hi Dmitry, Was this issue on our blocking list? Should it have been? We're now freezing beyond the point of ordinary fixes, so while you're free to commit to 'master' and mark them for inclusion in 25.2, we're locking down on what is accepted in emacs-25. Thanks, -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] emacs-25 4d8fd9c 4/4: Handle "empty line" regexp in xref searches 2016-05-03 23:08 ` [Emacs-diffs] emacs-25 4d8fd9c 4/4: Handle "empty line" regexp in xref searches John Wiegley @ 2016-05-03 23:18 ` Dmitry Gutov 2016-05-04 2:44 ` Eli Zaretskii 0 siblings, 1 reply; 3+ messages in thread From: Dmitry Gutov @ 2016-05-03 23:18 UTC (permalink / raw) To: emacs-devel, Eli Zaretskii Hi John, On 05/04/2016 02:08 AM, John Wiegley wrote: >> branch: emacs-25 >> commit 4d8fd9cf338cf9b5dfc613657adfeabff2d9c14e >> Author: Dmitry Gutov <dgutov@yandex.ru> >> Commit: Dmitry Gutov <dgutov@yandex.ru> > >> * lisp/progmodes/xref.el (xref--collect-matches-1): Stop after one >> match if re-search-forward doesn't move point (bug#23426). > Was this issue on our blocking list? Apparently not. > Should it have been? I believe so, yes. But if Eli thinks otherwise, feel free to revert it. There was another, considerably less critical, but also less risky change in the same push (6f82d8e). If anything, I expected that one to spark some discussion. It's straight up performance improvement, however. Again, feel free to revert in on emacs-25. Then I'll avoid making similar changes there. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] emacs-25 4d8fd9c 4/4: Handle "empty line" regexp in xref searches 2016-05-03 23:18 ` Dmitry Gutov @ 2016-05-04 2:44 ` Eli Zaretskii 0 siblings, 0 replies; 3+ messages in thread From: Eli Zaretskii @ 2016-05-04 2:44 UTC (permalink / raw) To: Dmitry Gutov; +Cc: emacs-devel > From: Dmitry Gutov <dgutov@yandex.ru> > Date: Wed, 4 May 2016 02:18:30 +0300 > > > Was this issue on our blocking list? > > Apparently not. Btw, I believe it's high time Someone should go over the blocking issues and remove any that we don't intend to fix before the release. > > Should it have been? > > I believe so, yes. But if Eli thinks otherwise, feel free to revert it. No, I don't think otherwise. Emacs that freezes is a bad bug that cannot be left in the release, IMO. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-04 2:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160503230207.9960.96573@vcs.savannah.gnu.org>
[not found] ` <E1axjKS-0002c8-KC@vcs.savannah.gnu.org>
2016-05-03 23:08 ` [Emacs-diffs] emacs-25 4d8fd9c 4/4: Handle "empty line" regexp in xref searches John Wiegley
2016-05-03 23:18 ` Dmitry Gutov
2016-05-04 2:44 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).