From: Dmitry Gutov <dgutov@yandex.ru>
To: emacs-devel@gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [Emacs-diffs] emacs-25 4d8fd9c 4/4: Handle "empty line" regexp in xref searches
Date: Wed, 4 May 2016 02:18:30 +0300 [thread overview]
Message-ID: <81e22f77-70c5-546c-e5fd-170d4e2272d8@yandex.ru> (raw)
In-Reply-To: <m2vb2uagf1.fsf@newartisans.com>
Hi John,
On 05/04/2016 02:08 AM, John Wiegley wrote:
>> branch: emacs-25
>> commit 4d8fd9cf338cf9b5dfc613657adfeabff2d9c14e
>> Author: Dmitry Gutov <dgutov@yandex.ru>
>> Commit: Dmitry Gutov <dgutov@yandex.ru>
>
>> * lisp/progmodes/xref.el (xref--collect-matches-1): Stop after one
>> match if re-search-forward doesn't move point (bug#23426).
> Was this issue on our blocking list?
Apparently not.
> Should it have been?
I believe so, yes. But if Eli thinks otherwise, feel free to revert it.
There was another, considerably less critical, but also less risky
change in the same push (6f82d8e). If anything, I expected that one to
spark some discussion. It's straight up performance improvement, however.
Again, feel free to revert in on emacs-25. Then I'll avoid making
similar changes there.
next prev parent reply other threads:[~2016-05-03 23:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160503230207.9960.96573@vcs.savannah.gnu.org>
[not found] ` <E1axjKS-0002c8-KC@vcs.savannah.gnu.org>
2016-05-03 23:08 ` [Emacs-diffs] emacs-25 4d8fd9c 4/4: Handle "empty line" regexp in xref searches John Wiegley
2016-05-03 23:18 ` Dmitry Gutov [this message]
2016-05-04 2:44 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81e22f77-70c5-546c-e5fd-170d4e2272d8@yandex.ru \
--to=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).