From: Dmitry Gutov <dgutov@yandex.ru>
To: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Cc: "Simen Heggestøyl" <simenheg@runbox.com>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: New feature in project.el: Remembering the previously used projects
Date: Sat, 30 May 2020 02:22:00 +0300 [thread overview]
Message-ID: <81be7027-4079-0de6-b4dc-d669cd4c6f71@yandex.ru> (raw)
In-Reply-To: <87h7vy9wrv.fsf@gmail.com>
On 30.05.2020 01:55, Kévin Le Gouguec wrote:
> I have one gripe with it though: I've rigged frame-title-format to show
> the basename of the project root directory[1], which means I have a call
> to project-current on every redisplay.
First thought: you can cache it based it the value of default-directory.
Which should cut down on these calls (which trigger directory
traversals, etc) dramatically, and should be an improvement either way.
> IIUC, when default-directory is inside a project, project-current now
> calls project--add-to-project-list-front, which in turn calls
> project--write-project-list.
>
> This slows down redisplay quite noticeably on my end[2]. I don't know
> what the best solution would be; does it sound acceptable to add an
> optional SKIP-LIST-UPDATE argument for project-current, or is it too
> much trouble for this peculiar use-case?
And another thought: maybe we should only add a project to the project
list if user interaction happened (i.e. going through
project-prompt-project-dir). Simen, what do you think?
The patch below mostly does that, except it misses the case when a
directory was selected from project-switch-project. To fix that, we
could either duplicate the bit of logic there, or undo, in part, the
commit 9f88356b6770fb710c47e277dbdb4ba31b463d08 (turn
project-prompt-project-dir back into project-prompt-project, to return a
project instance, and handle the addition to history in there).
Anyway, the quick patch:
diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index 1f2a4e8471..2611b04680 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -114,10 +114,11 @@ project-current
((unless project-current-inhibit-prompt
maybe-prompt)
(setq dir (project-prompt-project-dir)
- pr (project--find-in-directory dir))))
- (if pr
- (project--add-to-project-list-front pr)
- (project--remove-from-project-list dir)
+ pr (project--find-in-directory dir))
+ (if pr
+ (project--add-to-project-list-front pr)
+ (project--remove-from-project-list dir))))
+ (unless pr
(setq pr (cons 'transient dir)))
pr))
next prev parent reply other threads:[~2020-05-29 23:22 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 20:06 New feature in project.el: Remembering the previously used projects Dmitry Gutov
2020-05-28 23:05 ` Basil L. Contovounesios
2020-05-28 23:29 ` Dmitry Gutov
2020-05-29 7:31 ` Philip K.
2020-05-29 13:51 ` Dmitry Gutov
2020-05-29 15:54 ` Simen Heggestøyl
[not found] ` <871rn2ivne.fsf@simenheg@gmail.com>
2020-05-30 10:29 ` Philip K.
2020-06-02 17:04 ` Simen Heggestøyl
[not found] ` <5ed68784.1c69fb81.61518.35eeSMTPIN_ADDED_BROKEN@mx.google.com>
2020-06-03 11:28 ` Basil L. Contovounesios
2020-05-30 12:38 ` Dmitry Gutov
2020-06-02 17:14 ` Simen Heggestøyl
2020-05-30 21:57 ` Juri Linkov
2020-05-30 23:39 ` Dmitry Gutov
2020-06-01 23:01 ` Juri Linkov
2020-06-02 21:34 ` Dmitry Gutov
2020-06-03 20:13 ` Dmitry Gutov
2020-06-03 22:40 ` Juri Linkov
2020-06-03 23:13 ` Dmitry Gutov
2020-06-04 21:55 ` Juri Linkov
2020-06-04 22:37 ` Dmitry Gutov
2020-06-05 8:33 ` Philip K.
2020-06-05 8:42 ` Simen Heggestøyl
2020-06-05 11:44 ` Dmitry Gutov
2020-06-05 11:59 ` Philip K.
2020-06-05 13:59 ` Philip K.
2020-06-05 17:20 ` Dmitry Gutov
2020-06-06 1:24 ` Jamie Beardslee
2020-12-19 22:18 ` Dmitry Gutov
2020-06-06 23:46 ` Juri Linkov
2020-06-07 0:40 ` Dmitry Gutov
2020-06-07 22:38 ` Juri Linkov
2020-06-02 17:43 ` Simen Heggestøyl
[not found] ` <5ed68fe1.1c69fb81.45e50.0c7cSMTPIN_ADDED_BROKEN@mx.google.com>
2020-06-03 11:28 ` Basil L. Contovounesios
[not found] ` <87a71l2wjf.fsf@simenheg@gmail.com>
2020-06-02 17:57 ` Dmitry Gutov
2020-06-03 22:34 ` Juri Linkov
2020-06-03 23:17 ` Dmitry Gutov
2020-06-04 18:33 ` Simen Heggestøyl
2020-06-04 21:58 ` Juri Linkov
2020-05-31 13:00 ` Dmitry Gutov
2020-06-02 17:51 ` Simen Heggestøyl
[not found] ` <87k10picej.fsf@simenheg@gmail.com>
2020-06-02 21:33 ` Dmitry Gutov
[not found] ` <5ed13064.1c69fb81.4bf5e.dc8eSMTPIN_ADDED_BROKEN@mx.google.com>
2020-06-03 11:28 ` Basil L. Contovounesios
2020-06-03 11:27 ` Basil L. Contovounesios
2020-06-03 11:47 ` Dmitry Gutov
2020-06-03 13:38 ` Basil L. Contovounesios
2020-06-03 19:15 ` Simen Heggestøyl
[not found] ` <87lfl4x8p0.fsf@simenheg@gmail.com>
2020-06-03 20:11 ` Dmitry Gutov
2020-06-04 18:19 ` Simen Heggestøyl
2020-05-29 22:55 ` Kévin Le Gouguec
2020-05-29 23:22 ` Dmitry Gutov [this message]
2020-05-29 23:31 ` Dmitry Gutov
2020-05-30 0:42 ` Dmitry Gutov
2020-05-30 6:05 ` Simen Heggestøyl
[not found] ` <5ed1f7ae.1c69fb81.9b99b.4ce7SMTPIN_ADDED_BROKEN@mx.google.com>
2020-05-30 12:42 ` Kévin Le Gouguec
2020-05-30 13:17 ` Dmitry Gutov
2020-05-30 17:05 ` Dmitry Gutov
2020-05-30 18:29 ` Kévin Le Gouguec
2020-06-02 17:29 ` Simen Heggestøyl
[not found] ` <877dwuc5zu.fsf@simenheg@gmail.com>
2020-05-30 13:21 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81be7027-4079-0de6-b4dc-d669cd4c6f71@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=kevin.legouguec@gmail.com \
--cc=simenheg@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).