From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Assertion violation in pdumper.c Date: Mon, 17 Aug 2020 09:32:48 -0700 Organization: UCLA Computer Science Department Message-ID: <8122a2d9-0e5f-4635-d23c-567870f68c8a@cs.ucla.edu> References: <83r1s5gybp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------940D96BA8D1AAB41FA49FC8D" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25677"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: Pip Cet , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 17 18:34:17 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k7i5N-0006TO-Lu for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Aug 2020 18:34:13 +0200 Original-Received: from localhost ([::1]:40722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k7i5M-0002wv-Od for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Aug 2020 12:34:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7i45-0000sm-PY for emacs-devel@gnu.org; Mon, 17 Aug 2020 12:32:53 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:57990) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7i43-00072V-Dt; Mon, 17 Aug 2020 12:32:53 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1E6F21600DE; Mon, 17 Aug 2020 09:32:50 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 0cwVsv1Yk8G6; Mon, 17 Aug 2020 09:32:49 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id F0CC21600EB; Mon, 17 Aug 2020 09:32:48 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id X4xv0ZNSlSdk; Mon, 17 Aug 2020 09:32:48 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-75-82-69-226.socal.res.rr.com [75.82.69.226]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id C5EA61600DE; Mon, 17 Aug 2020 09:32:48 -0700 (PDT) Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgptUUlOQkV5QWNtUUJFQURB QXlIMnhvVHU3cHBHNUQzYThGTVpFb243NGRDdmM0K3ExWEEySjJ0QnkycHdhVHFmCmhweHhk R0E5Smo1MFVKM1BENGJTVUVnTjh0TFowc2FuNDdsNVhUQUZMaTI0NTZjaVNsNW04c0thSGxH ZHQ5WG0KQUF0bVhxZVpWSVlYL1VGUzk2ZkR6ZjR4aEVtbS95N0xiWUVQUWRVZHh1NDd4QTVL aFRZcDVibHRGM1dZRHoxWQpnZDdneDA3QXV3cDdpdzdlTnZub0RUQWxLQWw4S1lEWnpiRE5D UUdFYnBZM2VmWkl2UGRlSStGV1FONFcra2doCnkrUDZhdTZQcklJaFlyYWV1YTdYRGRiMkxT MWVuM1NzbUUzUWpxZlJxSS9BMnVlOEpNd3N2WGUvV0szOEV6czYKeDc0aVRhcUkzQUZINmls QWhEcXBNbmQvbXNTRVNORnQ3NkRpTzFaS1FNcjlhbVZQa25qZlBtSklTcWRoZ0IxRApsRWR3 MzRzUk9mNlY4bVp3MHhmcVQ2UEtFNDZMY0ZlZnpzMGtiZzRHT1JmOHZqRzJTZjF0azVlVThN Qml5Ti9iClowM2JLTmpOWU1wT0REUVF3dVA4NGtZTGtYMndCeHhNQWhCeHdiRFZadWR6eERa SjFDMlZYdWpDT0pWeHEya2wKakJNOUVUWXVVR3FkNzVBVzJMWHJMdzYrTXVJc0hGQVlBZ1Jy NytLY3dEZ0JBZndoU In-Reply-To: <83r1s5gybp.fsf@gnu.org> Content-Language: en-US Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/17 11:37:56 X-ACL-Warn: Detected OS = Linux 3.1-3.10 X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253898 Archived-At: This is a multi-part message in MIME format. --------------940D96BA8D1AAB41FA49FC8D Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 8/17/20 7:07 AM, Eli Zaretskii wrote: > - if (offset < dump_private.header.cold_start > + if (offset < dump_private.header.discardable_start Yes, that's a good fix. Thanks for finding and fixing this bug. I installed the attached. --------------940D96BA8D1AAB41FA49FC8D Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-assertion-violation-in-pdumper.c.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-assertion-violation-in-pdumper.c.patch" >From 3a17b9f265fd6d42e82f649533027b4531f9dabf Mon Sep 17 00:00:00 2001 From: Eli Zaretskii Date: Mon, 17 Aug 2020 09:30:02 -0700 Subject: [PATCH] Fix assertion violation in pdumper.c * src/pdumper.c (pdumper_find_object_type_impl): When checking last_mark_bits, require the offset to be less than discardable_start, not cold_start. This fixes a typo introduced in 2020-08-14T21:33:21Z!eggert@cs.ucla.edu (Bug#42832). --- src/pdumper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pdumper.c b/src/pdumper.c index 2d1b19283c..217ffa6783 100644 --- a/src/pdumper.c +++ b/src/pdumper.c @@ -4999,7 +4999,7 @@ pdumper_find_object_type_impl (const void *obj) if (offset % DUMP_ALIGNMENT != 0) return PDUMPER_NO_OBJECT; ptrdiff_t bitno = offset / DUMP_ALIGNMENT; - if (offset < dump_private.header.cold_start + if (offset < dump_private.header.discardable_start && !dump_bitset_bit_set_p (&dump_private.last_mark_bits, bitno)) return PDUMPER_NO_OBJECT; const struct dump_reloc *reloc = -- 2.17.1 --------------940D96BA8D1AAB41FA49FC8D--