From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Pip Cet <pipcet@gmail.com>, emacs-devel@gnu.org
Subject: Re: Assertion violation in pdumper.c
Date: Mon, 17 Aug 2020 09:32:48 -0700 [thread overview]
Message-ID: <8122a2d9-0e5f-4635-d23c-567870f68c8a@cs.ucla.edu> (raw)
In-Reply-To: <83r1s5gybp.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 239 bytes --]
On 8/17/20 7:07 AM, Eli Zaretskii wrote:
> - if (offset < dump_private.header.cold_start
> + if (offset < dump_private.header.discardable_start
Yes, that's a good fix. Thanks for finding and fixing this bug. I installed the
attached.
[-- Attachment #2: 0001-Fix-assertion-violation-in-pdumper.c.patch --]
[-- Type: text/x-patch, Size: 1063 bytes --]
From 3a17b9f265fd6d42e82f649533027b4531f9dabf Mon Sep 17 00:00:00 2001
From: Eli Zaretskii <eliz@gnu.org>
Date: Mon, 17 Aug 2020 09:30:02 -0700
Subject: [PATCH] Fix assertion violation in pdumper.c
* src/pdumper.c (pdumper_find_object_type_impl): When checking
last_mark_bits, require the offset to be less than
discardable_start, not cold_start. This fixes a typo introduced in
2020-08-14T21:33:21Z!eggert@cs.ucla.edu (Bug#42832).
---
src/pdumper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/pdumper.c b/src/pdumper.c
index 2d1b19283c..217ffa6783 100644
--- a/src/pdumper.c
+++ b/src/pdumper.c
@@ -4999,7 +4999,7 @@ pdumper_find_object_type_impl (const void *obj)
if (offset % DUMP_ALIGNMENT != 0)
return PDUMPER_NO_OBJECT;
ptrdiff_t bitno = offset / DUMP_ALIGNMENT;
- if (offset < dump_private.header.cold_start
+ if (offset < dump_private.header.discardable_start
&& !dump_bitset_bit_set_p (&dump_private.last_mark_bits, bitno))
return PDUMPER_NO_OBJECT;
const struct dump_reloc *reloc =
--
2.17.1
prev parent reply other threads:[~2020-08-17 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 14:07 Assertion violation in pdumper.c Eli Zaretskii
2020-08-17 16:28 ` Pip Cet
2020-08-17 16:32 ` Paul Eggert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8122a2d9-0e5f-4635-d23c-567870f68c8a@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).