unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Rüdiger Sonderfeld" <ruediger@c-plusplus.de>
To: Thien-Thi Nguyen <ttn@gnu.org>
Cc: emacs-devel@gnu.org
Subject: [PATCH] Add support for C++ headers to `ffap'.
Date: Fri, 20 Sep 2013 10:36:08 +0200	[thread overview]
Message-ID: <8118475.ycthmq3H9S@descartes> (raw)
In-Reply-To: <87bo3o83nq.fsf@zigzag.favinet>

It should have been `eq' to handle `ignore-errors' returning nil in
case of error.

Regards,
Rüdiger

----- 8< ------------------------------- >8 -------------

Using only `ffap-c-mode' does not work for C++ headers from
libstdc++.  Those headers are usually stored in
"/usr/include/c++/<version>/".

* lisp/ffap.el (ffap-c++-path): New variable.
(ffap-c++-mode): New function.
(ffap-alist): Use `ffap-c++-mode' for `c++-mode'.

Signed-off-by: Rüdiger Sonderfeld <ruediger@c-plusplus.de>
---
 lisp/ffap.el | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/lisp/ffap.el b/lisp/ffap.el
index 737de8b..d11c79c 100644
--- a/lisp/ffap.el
+++ b/lisp/ffap.el
@@ -769,7 +769,7 @@ (defvar ffap-alist
     ;; (lisp-interaction-mode . ffap-el-mode) ; maybe
     (finder-mode . ffap-el-mode)	; type {C-h p} and try it
     (help-mode . ffap-el-mode)		; maybe useful
-    (c++-mode . ffap-c-mode)		; search ffap-c-path
+    (c++-mode . ffap-c++-mode)		; search ffap-c++-path
     (cc-mode . ffap-c-mode)		; same
     ("\\.\\([chCH]\\|cc\\|hh\\)\\'" . ffap-c-mode) ; stdio.h
     (fortran-mode . ffap-fortran-mode)	; FORTRAN requested by MDB
@@ -866,6 +866,23 @@ (defvar ffap-c-path
 (defun ffap-c-mode (name)
   (ffap-locate-file name t ffap-c-path))
 
+(defvar ffap-c++-path
+  (let ((g++-version (with-temp-buffer
+                       (when (eq 0 (ignore-errors
+                                    (call-process "g++" nil t nil "-v")))
+                         (goto-char (point-min))
+                         (when (re-search-forward "gcc version \
+\\([[:digit:]]+.[[:digit:]]+.[[:digit:]]+\\)"
+                                                  nil 'noerror)
+                           (match-string 1))))))
+    (if g++-version
+        (cons (concat "/usr/include/c++/" g++-version) ffap-c-path)
+      ffap-c-path))
+  "List of directories to search for include files.")
+
+(defun ffap-c++-mode (name)
+  (ffap-locate-file name t ffap-c++-path))
+
 (defvar ffap-fortran-path '("../include" "/usr/include"))
 
 (defun ffap-fortran-mode (name)
-- 
1.8.4




  parent reply	other threads:[~2013-09-20  8:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-19 21:51 [PATCH] Add support for C++ headers to `ffap' Rüdiger Sonderfeld
2013-09-20  5:26 ` Thien-Thi Nguyen
2013-09-20  5:47   ` Kalle Olavi Niemitalo
2013-09-20  8:47     ` Andreas Schwab
2013-09-20  8:36   ` Rüdiger Sonderfeld [this message]
2013-10-19  2:36     ` Glenn Morris
2013-09-20 10:10 ` [PATCH 2] " Rüdiger Sonderfeld
2013-09-30 22:11   ` Rüdiger Sonderfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8118475.ycthmq3H9S@descartes \
    --to=ruediger@c-plusplus.de \
    --cc=emacs-devel@gnu.org \
    --cc=ttn@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).