unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Fabrice Niessen" <fgdmjuzqrjgh-geNee64TY+gS+FvcfC7Uqw@public.gmane.org>
To: emacs-devel-mXXj517/zsQ@public.gmane.org
Subject: Re: Submitting a custom theme for GNU Emacs 24
Date: Thu, 29 Nov 2012 22:38:09 +0100	[thread overview]
Message-ID: <80y5hkw0n2.fsf@somewhere.org> (raw)
In-Reply-To: 87haojxcpc.fsf@yandex.ru

Hi Dmitry,

Dmitry Gutov wrote:
> "Fabrice Niessen" writes:
>> Please find attached a custom theme (with a light background -- one of the
>> few) that I'd like to see included in Emacs 24.
>
> Here's some feedback on the theme, if you don't mind:

A first, quick but late, reaction. No, of course, I really don't mind at all.
On the contrary, I'm willing to get as many reactions as possible. That does
not mean I'll apply them all, but you always can try to convince me.

> 1) For the most part, the colors look good, the mode-line looks rather
>    modern, at last.

Thanks. Yeah, very nice mode-line, IMHO, both the active and the inactive one.

> 2) The red color of the comments looks grating, hard on the eyes.

I like that. I can try to find alternative tints, but please know that I'm
fond of comments, and consider them as one of the most important part of the
code. I mean, when they are some, they often are very important to be read.
Hence, more a choice in the direction of the red, than in the direction of the
light gray -- as often done.

> 3) The gnus message window looks very uneven.

Yes, apparently, we don't use the same good-looking fonts. What fonts are you
using? On which system?

One problem may come as well from the fact I mixed (on purpose) proportional
and non-proportional types of fonts for the different elements of the mail
header. Maybe that's not such a great idea...

> 4) The helm buffer looks rather bizarre.

Can you be more precise?  Are you talking of the different colors depending on
the type of files?  Are you talking of the inverse video used for the current
(highlighted) line?

> For 3 and 4, see attached screenshots.

Thanks a lot!

Best regards,
Fabrice

--
Fabrice Niessen
Search the Web with "My Google Search Tools" on http://www.MyGooglest.com




      reply	other threads:[~2012-11-29 21:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15 13:50 Submitting a custom theme for GNU Emacs 24 Fabrice Niessen
2012-11-20 13:22 ` Fabrice Niessen
2012-11-21 12:56   ` Chong Yidong
2012-11-21 14:17 ` Dmitry Gutov
2012-11-29 21:38   ` Fabrice Niessen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80y5hkw0n2.fsf@somewhere.org \
    --to=fgdmjuzqrjgh-genee64ty+gs+fvcfc7uqw@public.gmane.org \
    --cc=emacs-devel-mXXj517/zsQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).