Submitting a custom theme for GNU Emacs 24

Submitting a custom theme for GNU Emacs 24

[Fabrice Niessen]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

Hello,

Please find attached a custom theme (with a light background -- one of the
few) that I'd like to see included in Emacs 24.

Best regards,
Fabrice Niessen

[-- Attachment #2: leuven-theme.el --]
[-- Type: application/emacs-lisp, Size: 40120 bytes --]

Re: Submitting a custom theme for GNU Emacs 24

[Fabrice Niessen]

Hello,

"Fabrice Niessen" wrote:
> Please find attached a custom theme (with a light background -- one of the
> few) that I'd like to see included in Emacs 24.

Is this the right way for making such a submission?

Best regards,
Fabrice Niessen

Re: Submitting a custom theme for GNU Emacs 24

[Chong Yidong]

"Fabrice Niessen" <fni@missioncriticalit.com> writes:

>> Please find attached a custom theme (with a light background -- one
>> of the few) that I'd like to see included in Emacs 24.
>
> Is this the right way for making such a submission?

Yes, it's just that I've been too busy to answer emails in the last
week.  The theme looks good, and I'll be happy to include it.  We'll
need you to make a copyright assignment to the FSF so that we can
distribute it; I'll email you off-list with the procedure.

Re: Submitting a custom theme for GNU Emacs 24

[Dmitry Gutov]

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]

"Fabrice Niessen"
<fni-djc/iPCCuDYQheJpep6IedvLeJWuRmrY@public.gmane.org> writes:

> Hello,
>
> Please find attached a custom theme (with a light background -- one of the
> few) that I'd like to see included in Emacs 24.

Here's some feedback on the theme, if you don't mind:
1) For the most part, the colors look good, the mode-line looks rather
modern, at last.
2) The red color of the comments looks grating, hard on the eyes.
3) The gnus message window looks very uneven.
4) The helm buffer looks rather bizarre.

For 3 and 4, see attached screenshots.

[-- Attachment #2: leuven-gnus.png --]
[-- Type: image/png, Size: 20436 bytes --]

[-- Attachment #3: leuven-helm.png --]
[-- Type: image/png, Size: 22617 bytes --]

Re: Submitting a custom theme for GNU Emacs 24

[Fabrice Niessen]

Hi Dmitry,

Dmitry Gutov wrote:
> "Fabrice Niessen" writes:
>> Please find attached a custom theme (with a light background -- one of the
>> few) that I'd like to see included in Emacs 24.
>
> Here's some feedback on the theme, if you don't mind:

A first, quick but late, reaction. No, of course, I really don't mind at all.
On the contrary, I'm willing to get as many reactions as possible. That does
not mean I'll apply them all, but you always can try to convince me.

> 1) For the most part, the colors look good, the mode-line looks rather
>    modern, at last.

Thanks. Yeah, very nice mode-line, IMHO, both the active and the inactive one.

> 2) The red color of the comments looks grating, hard on the eyes.

I like that. I can try to find alternative tints, but please know that I'm
fond of comments, and consider them as one of the most important part of the
code. I mean, when they are some, they often are very important to be read.
Hence, more a choice in the direction of the red, than in the direction of the
light gray -- as often done.

> 3) The gnus message window looks very uneven.

Yes, apparently, we don't use the same good-looking fonts. What fonts are you
using? On which system?

One problem may come as well from the fact I mixed (on purpose) proportional
and non-proportional types of fonts for the different elements of the mail
header. Maybe that's not such a great idea...

> 4) The helm buffer looks rather bizarre.

Can you be more precise?  Are you talking of the different colors depending on
the type of files?  Are you talking of the inverse video used for the current
(highlighted) line?

> For 3 and 4, see attached screenshots.

Thanks a lot!

Best regards,
Fabrice

--
Fabrice Niessen
Search the Web with "My Google Search Tools" on http://www.MyGooglest.com