From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Emacs 26.2 etags.c warning Date: Fri, 3 May 2019 12:41:09 -0700 Organization: UCLA Computer Science Department Message-ID: <8097bd03-8fac-1b68-f1f2-4b3a3c9f3319@cs.ucla.edu> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------E7CD24150DFE84EB57111B1D" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="256221"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: emacs-devel@gnu.org To: noloader@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 03 23:14:12 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMfVT-0012u5-Jz for ged-emacs-devel@m.gmane.org; Fri, 03 May 2019 23:14:11 +0200 Original-Received: from localhost ([127.0.0.1]:46521 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMe3g-00012H-Bc for ged-emacs-devel@m.gmane.org; Fri, 03 May 2019 15:41:24 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMe3X-000128-E0 for emacs-devel@gnu.org; Fri, 03 May 2019 15:41:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMe3W-0001Ed-3O for emacs-devel@gnu.org; Fri, 03 May 2019 15:41:15 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:49388) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hMe3U-00011a-CA for emacs-devel@gnu.org; Fri, 03 May 2019 15:41:13 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 46A22161925; Fri, 3 May 2019 12:41:10 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 9uKUqM8Xy1hX; Fri, 3 May 2019 12:41:09 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 6339D161927; Fri, 3 May 2019 12:41:09 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id e77cIEeqRjpM; Fri, 3 May 2019 12:41:09 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 460B0161357; Fri, 3 May 2019 12:41:09 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236108 Archived-At: This is a multi-part message in MIME format. --------------E7CD24150DFE84EB57111B1D Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 5/3/19 7:50 AM, Jeffrey Walton wrote: > etags.c:88: warning: "NDEBUG" redefined > # define NDEBUG /* disable assert */ > > Maybe guard the define? That's already done in the Emacs master branch. Come to think of it, the NDEBUG stuff in etags.c can be simplified to avoid this mess entirely. I installed the attached into master to do that. --------------E7CD24150DFE84EB57111B1D Content-Type: text/x-patch; name="0001-Simplify-use-of-NDEBUG-in-etags.c.patch" Content-Disposition: attachment; filename="0001-Simplify-use-of-NDEBUG-in-etags.c.patch" Content-Transfer-Encoding: quoted-printable >From 0c672d2e3f11ae13ec35cc6c5615f745d233e686 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 3 May 2019 12:38:28 -0700 Subject: [PATCH] Simplify use of NDEBUG in etags.c MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit * lib-src/etags.c [!DEBUG]: Do not define NDEBUG, as that=E2=80=99s conf_post.h=E2=80=99s job now. [NDEBUG]: Do not redefine =E2=80=98assert=E2=80=99, as that works around ancient bugs (e.g., sunos4 pcc) that don=E2=80=99t matter any more, as can be seen that other Emacs source files that successfully use assert.h without this workaround. --- lib-src/etags.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/lib-src/etags.c b/lib-src/etags.c index 362897fb0c..949ab5a2c6 100644 --- a/lib-src/etags.c +++ b/lib-src/etags.c @@ -84,10 +84,7 @@ char pot_etags_version[] =3D "@(#) pot revision number= is 17.38.1.4"; # undef DEBUG # define DEBUG true #else -# define DEBUG false -# ifndef NDEBUG -# define NDEBUG /* disable assert */ -# endif +# define DEBUG false #endif =20 #include @@ -131,11 +128,6 @@ char pot_etags_version[] =3D "@(#) pot revision numb= er is 17.38.1.4"; #include =20 #include -#ifdef NDEBUG -# undef assert /* some systems have a buggy assert.h */ -# define assert(x) ((void) 0) -#endif - #include #include =20 --=20 2.21.0 --------------E7CD24150DFE84EB57111B1D--