From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 4) Date: Sun, 9 May 2021 21:11:01 +0200 Message-ID: <809793ed-6228-c4e4-a3f9-62f12cbd8654@daniel-mendler.de> References: <0bbdeece-90d5-160c-07ec-2ad8edbf9872@daniel-mendler.de> <87czudm7bv.fsf@mail.linkov.net> <976056e8-3d46-db27-32c2-ddf3ca32d5a7@daniel-mendler.de> <878s5090e9.fsf@mail.linkov.net> <69fd42ed-a1a0-adcb-ac8b-caad80cb0967@daniel-mendler.de> <878s4zzpvc.fsf@mail.linkov.net> <95ac7ef3-5e8c-fc58-b316-544096c82aa0@daniel-mendler.de> <87o8dus00b.fsf@mail.linkov.net> <6718c89f-88a0-b529-1676-7e89fc152f00@daniel-mendler.de> <878s4w3law.fsf@mail.linkov.net> <87sg2ymq6j.fsf@mail.linkov.net> <78bb0663-80ef-a68f-c582-cd7cc0436c29@daniel-mendler.de> <069cec7d-db2c-8628-69fb-a2aee4ee5074@daniel-mendler.de> <6ac36d0f-bf5b-2124-1f70-69644bb40218@daniel-mendler.de> <871rafrdny.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28104"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gregory Heytings , Dmitry Gutov , "emacs-devel@gnu.org" , Juri Linkov To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 09 21:11:54 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfoqI-0007DU-F1 for ged-emacs-devel@m.gmane-mx.org; Sun, 09 May 2021 21:11:54 +0200 Original-Received: from localhost ([::1]:33050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfoqG-0007B7-8s for ged-emacs-devel@m.gmane-mx.org; Sun, 09 May 2021 15:11:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfopa-0006W5-IO for emacs-devel@gnu.org; Sun, 09 May 2021 15:11:10 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:52787 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfopW-0006bx-Uu for emacs-devel@gnu.org; Sun, 09 May 2021 15:11:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=794bn4zDcjXq4t8BoocOQ2sWawmH/z/LRC17LXwiDaQ=; b=wsm8F8mnA+0Q5Uz0o+VPhBQvmf D6zHYwoxEXae40U9Y2PwHhumDMLrcwAlbniBuojSZIaP9tR9RIIoDS4EtGb7fL8kzdv2mFVGQV001 kKFrU6bkTZ2M8EsGHNyS9RmLE8xWciHbZukBjXHHEScQiy/sEqglWImvWOS3je0jXz9M=; In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269094 Archived-At: On 5/9/21 8:56 PM, Stefan Monnier wrote: > I think in the case of the ucs-char-names completion-table, the group > sorting option we propose (alphabetical) is not really specific to the > completion table, so I don't see the point of putting the control (and > work) in the hands of the completion-table. Yes, and I don't think there many sensible options on how you want to sort the groups after all. Therefore it is questionable if the generalization of the `group-function` is needed. Either one uses the natural candidate order to determine the group order or one sorts the groups alphabetically. In the case of vertical UIs like Ivy, Selectrum and Vertico I prefer to have the candidate order determine the group order, since this ensures that the most likely candidate occurs first. In the case of the default completion UI it may be more reasonable to always sort the groups alphabetically, such that the overall view is more predictable. However if it turns out that we need the generality in the end it may be better to include the possibility right away as I proposed in my last patch. Daniel