From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= Newsgroups: gmane.emacs.devel Subject: Re: "Why is emacs so square?" Date: Fri, 17 Apr 2020 11:52:56 -0400 Message-ID: <8001bd11-b552-e94e-d15a-30f9bd34f71b@gmail.com> References: <8wXYP4GY9hwW-9mYv6_LGMETZ8Vz3Ob1Bec6yh6kPT7yxjTkxA3V6dXY4ELra9tYiJUxJmgXKSIEX4w8HFiPRoeGVSQHDSoBVy1voj1e3Qo=@protonmail.com> <87wo6h1kwl.fsf@emailmessageidheader.nil> <83k12hgt43.fsf@gnu.org> <838siwhmco.fsf@gnu.org> <0348a76e-d55a-2e75-8ed1-1beaa6649ed6@gmail.com> <837dyfe45q.fsf@gnu.org> <245308ec-5154-7d4b-dba4-0b21f42a0e95@gmail.com> <835zdze1gs.fsf@gnu.org> <51cb2788-3086-367d-ec05-ea324da49a12@gmail.com> <83imhyd1w1.fsf@gnu.org> <83f35fb6-806e-1b28-da76-31919a398045@gmail.com> <833692cgr4.fsf@gnu.org> <6479af83-2cab-05b0-3042-8030ec3f1e1d@gmail.com> <83wo6eazrd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="31458"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 17 17:54:46 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jPTKH-00085w-Tf for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Apr 2020 17:54:45 +0200 Original-Received: from localhost ([::1]:48874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPTKH-0004t8-0N for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Apr 2020 11:54:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55988) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPTIZ-0002oe-L5 for emacs-devel@gnu.org; Fri, 17 Apr 2020 11:53:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jPTIY-0002pV-I6 for emacs-devel@gnu.org; Fri, 17 Apr 2020 11:52:59 -0400 Original-Received: from mail-qv1-xf29.google.com ([2607:f8b0:4864:20::f29]:45366) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jPTIY-0002pG-EK; Fri, 17 Apr 2020 11:52:58 -0400 Original-Received: by mail-qv1-xf29.google.com with SMTP id p13so1096986qvt.12; Fri, 17 Apr 2020 08:52:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Wp1viuufjkCG5L6BKYDJbEwnFlyIRXn/4zlhfEixMgA=; b=V8aEMsfykXxh9+6z8fCZz6Wdy1CsRneUYAU/hlNZzhuGgMBNKqsD6LXEVZbK5m5VcQ A04jPwcodXINq+0OpQdSEqD5k4mmF5t9X+tHlETGt78fiAI0zk4IoE2+W3jipiOZCSF9 du6t/tddAbzZSEo//7H6o9/w3KaugvaLB11d9T/JEFuHcDsoFUDAgPRJbBVkoLemVQca 7RBhsdMe/H5USxdySHklsFCX85LMGniFguUIHbN3yjNchnFhjT6BBoE9RTA7eR7f6iO1 ZvlWjv6IQ+kA8Tr9SR3WtDbe74EiBkqe9yogjrUfRJjRiM8J8ylPWrjmhEjEXrG3M/np 5pQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Wp1viuufjkCG5L6BKYDJbEwnFlyIRXn/4zlhfEixMgA=; b=Kha1lZBdY7b5/h6TtHL2bQtUibYGaFBJT95rs5u3AGX11vaCrz5UqKm2BegZpgZYBa cPEKTpkcqp3yKPgdAr4fC7PI6Y5HQ3M6+koEkceffGNuURAMB2p6PgBvagOFUtl309qW HvkFI9YUVeOeLP8y7xiC7W4DUE9wL8yq23dq4BsXZ9HAmjs2FemK9PCNmjZbJUF0RD9q 8GWzuvzArTHPTb3/Kw6c6bASpwZ1tzl1wMH3janmljyEvg2XvsLbSs85HvIgrRCEZlSq 9rTAn7Otf02BU5IC0ihYQlof56Yzthvt+QeAu1te9tAjQzV7+23wlFl48Pwpq02QgkpO L+xA== X-Gm-Message-State: AGi0Pua726eOAPkr/dymq2e57ps34HIxMbZKSfDlddx6ENet5995pD1L R4Ee4vVUU2BpH6DGAljWvKeRDrmk X-Google-Smtp-Source: APiQypK37F4CaSCT7aFvykcsVUAiz/hVhREVwUoKOm3H8izSSWZSrDYHRATmgwICVlVLoh0f4lTUPQ== X-Received: by 2002:ad4:4242:: with SMTP id l2mr3283883qvq.98.1587138777670; Fri, 17 Apr 2020 08:52:57 -0700 (PDT) Original-Received: from ?IPv6:2601:184:4180:66e7:da2:5c19:86dd:363e? ([2601:184:4180:66e7:da2:5c19:86dd:363e]) by smtp.googlemail.com with ESMTPSA id p24sm16601578qtp.59.2020.04.17.08.52.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Apr 2020 08:52:57 -0700 (PDT) In-Reply-To: <83wo6eazrd.fsf@gnu.org> Content-Language: en-GB X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::f29 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247176 Archived-At: On 17/04/2020 11.38, Eli Zaretskii wrote: >> Cc: emacs-devel@gnu.org >> From: Clément Pit-Claudel >> Date: Fri, 17 Apr 2020 11:27:56 -0400 >> >>> I don't know. AFAIK, we don't have infrastructure for deciding when >>> stuff like that needs to be re-evaluated and how to use different >>> results for different frames. If someone wants to work on such >>> infrastructure, I think it will bring us a step closer to being able >>> to support different GUI frame types (like GTK, w32, NS, etc.) in the >>> same session. >> >> I may be missing something, but I don't think such infrastructure is needed here — we already have most of what's needed with conditional faces. > > Faces were always per-frame (although when you customize a face, it > changes on all frames), but faces are just the tip of the iceberg. > The general problem with GUI features is much wider. I thought you > were talking about the more general problem. I'm talking only about the OP's problem, which was that buttons were not displayed in 3D. >> The attached patch gets us 90% of the way, with the only remaining issue being wrapping buttons in square brackets on text terminals. >> >> (defface custom-button-pressed >> '((((type x w32 ns) (class color)) >> :box (:line-width 2 :style pressed-button) >> :background "lightgrey" :foreground "black") >> - (t :inverse-video t)) >> + (t :inherit custom-button-pressed-unraised)) >> "Face for pressed custom buttons if `custom-raised-buttons' is non-nil." >> :version "21.1" >> :group 'custom-faces) > > Why a separate face, instead of a separate definition of the same face > for non-GUI displays? To be able to honor the custom-raised-buttons setting. I wouldn't design it that way, but that's where we are. > Anyway, the condition should not be on frame types, but rather on > capabilities, IMO. Agreed. Do you know how the problem with square brackets could be solved? Currently the custom-raised-buttons setting is used to chose a face and to decide whether to insert square brackets around buttons. Is there a clean way to make these brackets display only in text terminals?