From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: wsnyder@wsnyder.org (Wilson Snyder) Newsgroups: gmane.emacs.devel Subject: Backslash cleanup introduced bug [284c470e 9/17] Date: Fri, 18 Sep 2015 08:34:37 -0400 Message-ID: <7qsi6bc3du.fsf@emma.svaha.wsnyder.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1442579704 32404 80.91.229.3 (18 Sep 2015 12:35:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 18 Sep 2015 12:35:04 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 18 14:34:59 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZcusJ-0004Dv-NZ for ged-emacs-devel@m.gmane.org; Fri, 18 Sep 2015 14:34:47 +0200 Original-Received: from localhost ([::1]:37797 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcusJ-0001DB-8X for ged-emacs-devel@m.gmane.org; Fri, 18 Sep 2015 08:34:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcusF-0001Ce-G8 for emacs-devel@gnu.org; Fri, 18 Sep 2015 08:34:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcusC-0004WK-8y for emacs-devel@gnu.org; Fri, 18 Sep 2015 08:34:43 -0400 Original-Received: from vpo3.wsnyder.org ([173.230.154.183]:53846 helo=wsnyder.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcusC-0004VD-3S for emacs-devel@gnu.org; Fri, 18 Sep 2015 08:34:40 -0400 X-ssh-sendmail: true User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 173.230.154.183 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:190054 Archived-At: Thanks for your recent quoting cleanup commit. One of your cleanups broke the verilog-mode.el package regressions. I've repaired it; no additional action is needed, but a heads up in case this affects other packages. This: - "==" "!=" "===" "!==" "<=" ">=" "==\?" "!=\?" "<->" + "==" "!=" "===" "!==" "<=" ">=" "==\\?" "!=\\?" "<->" was a list of operators, not a series of regexps, so this change will break matching `==?' (it will look for `==\?'. Therefore the proper cleanup is: - "==" "!=" "===" "!==" "<=" ">=" "==\?" "!=\?" "<->" + "==" "!=" "===" "!==" "<=" ">=" "==?" "!=?" "<->" Also: (verilog-string-replace-matches - "\[[^0-9: \t]+\]" "" nil nil + "\\[[^0-9: \t]+]" "" nil nil While I agree it works, I think quoting literal open brackets without quoting literal closing brackets makes it harder to read - which closing bracket matches the literal open bracket? (verilog-string-replace-matches - "\[[^0-9: \t]+\]" "" nil nil + "\\[[^0-9: \t]+\\]" "" nil nil I find this is easier to read as the \\[ and \\] form a matching pair. Furthermore I can see any unquoted closing bracket and know it is part of a character class; and see any quoted closing bracket and know it matches a literal. Thanks