From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: MPS: Change some macros to functions Date: Thu, 11 Jul 2024 13:35:44 +0000 Message-ID: <7pk3cN4EA2JGOKgO5Kfu25n2qr_JHU0L2BCRP9vUpRcRGoCMVYwoO0zS_b2Ft41NkZgS2CjbHmV4vL5Ht2KWGibeLLCYZkQH4IvOQ1I-7W4=@protonmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10036"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel , Helmut Eller To: =?utf-8?Q?Gerd_M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 11 16:04:38 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRuPT-0002CY-Cg for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Jul 2024 16:04:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRuOz-0004vj-Nt; Thu, 11 Jul 2024 10:04:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRtxr-0002Bl-GH for emacs-devel@gnu.org; Thu, 11 Jul 2024 09:36:05 -0400 Original-Received: from mail-4322.protonmail.ch ([185.70.43.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRtxn-0003sF-6b for emacs-devel@gnu.org; Thu, 11 Jul 2024 09:36:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1720704950; x=1720964150; bh=zO1kClp1BXFak9t1ps//XbCCXge5ky0NRTeK6Vhyz6w=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=yJ+My3GYql+B5MA8GPPaWxG9OhCN3aOXFjLOvgv2+flWssOWfgok6ZL5NfSldMmtr MWJSAlMgayaB7LFqRW2ljPzP50xunpQ75jW47LZHZL+eNdQPEaLyoxB8KAHDjnP4Tg PZcS2xglhmyBHSz5kY59rnc2Z3/xEGYHZXsFa4pU4edEAVFY3S9/lKbLEUrcOEfLUZ YOY7fBLfNzYIDyhk2hF5srxTJhPQ/eHOk/FdpytZREmhGwupBhiOQhV/kgGBaXu5kz XTv+j2Wano+WsaAtGph9eeZxO0nNa/G7t43J7Nb69iwxU5G5IYwZzjd7dEx5QYqzVD 5q5h84sM0yAig== In-Reply-To: Feedback-ID: 112775352:user:proton X-Pm-Message-ID: d45d013676b34ebdfe1739e52c507a4a4ee91069 Received-SPF: pass client-ip=185.70.43.22; envelope-from=pipcet@protonmail.com; helo=mail-4322.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 11 Jul 2024 10:03:57 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321591 Archived-At: On Thursday, July 11th, 2024 at 13:01, Gerd M=C3=B6llmann wrote: > Gerd M=C3=B6llmann gerd.moellmann@gmail.com writes: >=20 > > Any objections against changing these to functions? No objections at all. Thanks! > > #define IGC_HEADER_NWORDS(h) ((h)->v >> IGC_HEADER_NWORDS_SHIFT) > > #define IGC_HEADER_HASH(h) (((h)->v >> IGC_HEADER_HASH_SHIFT) & IGC_HEA= DER_HASH_MASK) > > #define IGC_HEADER_TYPE(h) (((h)->v >> IGC_HEADER_TYPE_SHIFT) & IGC_HEA= DER_TYPE_MASK) > > #define IGC_HEADER_TAG(h) ((h)->v & IGC_HEADER_TAG_MASK) > >=20 > > LLDB can't handle macros, and having return types would also be nice. > >=20 > > I can do that if you agree. Of course! No need to ask, really. > Something like That looks good to me, and I can easily adjust all the stuff I'm working on= that's still not quite working yet :-) Pip