From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: imagemagic in image-mode and image-dired-thumbnail-mode? Date: Tue, 16 Jul 2013 11:57:49 -0400 Message-ID: <7m61wats3m.fsf@fencepost.gnu.org> References: <87a9lp8uxk.fsf@gmail.com> <87ppuk6qqb.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1373990275 22768 80.91.229.3 (16 Jul 2013 15:57:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 16 Jul 2013 15:57:55 +0000 (UTC) Cc: joakim@verona.se, emacs-devel@gnu.org To: Vitalie Spinu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 16 17:57:56 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Uz7dT-0006Qo-TU for ged-emacs-devel@m.gmane.org; Tue, 16 Jul 2013 17:57:56 +0200 Original-Received: from localhost ([::1]:44150 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz7dT-0003av-Jb for ged-emacs-devel@m.gmane.org; Tue, 16 Jul 2013 11:57:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz7dP-0003YT-O3 for emacs-devel@gnu.org; Tue, 16 Jul 2013 11:57:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uz7dO-0002pO-N3 for emacs-devel@gnu.org; Tue, 16 Jul 2013 11:57:51 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz7dO-0002pJ-Ja for emacs-devel@gnu.org; Tue, 16 Jul 2013 11:57:50 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Uz7dN-0001im-SM; Tue, 16 Jul 2013 11:57:49 -0400 X-Spook: Putin ASIO Uzbekistan bemd AMEMB argus Skipjack COSCO X-Ran: xHn (Vitalie Spinu's message of "Mon, 15 Jul 2013 12:51:24 +0200") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:161934 Archived-At: Vitalie Spinu wrote: > I am wiling to propose a series of patches to image.el and image-mode.el > in order to implement scaling, transform functionality and auto-fit to > image window. From what I see it will be quite an extensive change. So I > ask before doing anything. > > First of all there is no image universal api for transforms. The > functions image-transform-XXX in image-mode are very image-mode specific > and all operate by side effects and rely on (many) global variables and > image-toggle-display-image function (the core of image-mode). > > So the proposal is to rewrite all those transform functions into a > consistent image transform api and move them into image.el. FWIW, that sounds good to me.