From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pieter van Prooijen Newsgroups: gmane.emacs.devel Subject: Re: Compilation of src/xsettings.c fails when configured with --without_gsettings Date: Sat, 14 May 2022 21:44:59 +0200 Message-ID: <7fe4e3a2d8799ce34fb2449f3057db4f67f71ba1.camel@teloden.nl> References: <87lev4otq5.fsf@tammy.lan.sha-bang.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37059"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.44.0-1ubuntu1 To: wilde@sha-bang.de, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 14 21:46:03 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1npxiE-0009QV-AX for ged-emacs-devel@m.gmane-mx.org; Sat, 14 May 2022 21:46:02 +0200 Original-Received: from localhost ([::1]:41156 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npxiC-0006Dr-U4 for ged-emacs-devel@m.gmane-mx.org; Sat, 14 May 2022 15:46:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npxhM-0005SE-TF for emacs-devel@gnu.org; Sat, 14 May 2022 15:45:08 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:56425) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npxhK-0008O7-FX for emacs-devel@gnu.org; Sat, 14 May 2022 15:45:08 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 6B1235C012F; Sat, 14 May 2022 15:45:04 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 14 May 2022 15:45:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=teloden.nl; h=cc :content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1652557504; x= 1652643904; bh=MxdIaSGsMZSTZe4TpJue8wJGlDkdmDCZNvTD5oAYqa0=; b=K FKBmcFOt4wh25+aWMrLRfQ/N/V43D07nU2aB2PsMHAbdIRmdk0ACJzefHQn25TPp PjnRweWlkEUDoeyVXBX9i8zMHpsebqPCxD+WUegjz+W/JQ1Elm226LhmfsRsG1+L gYsmDoCz8xg1gJZ05lM19qPyTqIjLNFH4Q/YsPMVmltvmEeL81WUcLAFqmm4kXRt X8EEkn26RZpvS8N5c3/nvWCRlILo5aDEVIzZXvAOvTx3+ysgPsiVwfFVoK44OrWx 7+eJ2T2NwZheNFN9T9MY4vANcO0G2XwcYEhyeQ8Xgh17vo7/d+Q3EPREpzujhCQq +BIK2Genc/VWQ54KYnsug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1652557504; x=1652643904; bh=MxdIaSGsMZSTZe4TpJue8wJGlDkd mDCZNvTD5oAYqa0=; b=Gz7EQmcgDDuOA9jjuh6WyiSfoYA+73l8URN8ukvTSpi0 R36KCl0gkLNsyu5j/8ODbPQEM0U4xSpBifhOYWFA58G/aBt36wT6LCSaz80DE5KZ cdLIQtmYc3Hfk08ouF4L/9x9V7Sf6unzUriXw43U0Gh94GI+6pI++Vr6XDnzQexY rsJn3DTOv0iR20HpLrVyQJYdLtW+pIce9V8L4LNqT8bFV++7ZEDmpAvq+FMB76Or JovGMY1ccqYYyxPVuKHM9PkBQv8XYAU3/b/Mc85GilJHoS/8Q/UzdpteAui02Axp uaCCf2oj7TjPCYM/kLXRbK4/YF+/dUul/w/JuJg5pQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrhedugddufeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkuffhvfffjghftgfgfgggsehtqh ertddtreejnecuhfhrohhmpefrihgvthgvrhcuvhgrnhcurfhrohhoihhjvghnuceophhi vghtvghrrdhvrghnrdhprhhoohhijhgvnhesthgvlhhouggvnhdrnhhlqeenucggtffrrg htthgvrhhnpeevledvvefffffhtdetfefhgefgudevfeeigeehgeehgefgleehueevtedv fefgkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hpihgvthgvrhdrvhgrnhdrphhrohhoihhjvghnsehtvghlohguvghnrdhnlh X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 14 May 2022 15:45:02 -0400 (EDT) In-Reply-To: <87lev4otq5.fsf@tammy.lan.sha-bang.de> Received-SPF: pass client-ip=66.111.4.26; envelope-from=pieter.van.prooijen@teloden.nl; helo=out2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289784 Archived-At: Hi Sascha, It looks like my gsettings font changes needs some extra ifdef guards to handle this case. I'll create a bug and patch for this in bug-gnu- emacs. Thanks, Pieter =C2=A0 On Sat, 2022-05-14 at 20:27 +0200, wilde@sha-bang.de wrote: > Hi *, >=20 > When HAVE_GSETTINGS is not defined (e.g. --without-gsettings > configuration option), but HAVE_PGTK is defined, then compilation of > src/xsettings.c fails with: >=20 > ../../src/xsettings.c: In function =E2=80=98xsettings_get_font_options=E2= =80=99: > ../../src/xsettings.c:1163:35: error: =E2=80=98font_options=E2=80=99 unde= clared > (first use in this function) > =C2=A01163 |=C2=A0=C2=A0 return cairo_font_options_copy (font_options); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 ^~~~~~~~~~~~ > ../../src/xsettings.c:1163:35: note: each undeclared identifier is > reported only once for each function it appears in > ../../src/xsettings.c: In function =E2=80=98syms_of_xsettings=E2=80=99: > ../../src/xsettings.c:1220:3: error: =E2=80=98font_options=E2=80=99 undec= lared (first > use in this function) > =C2=A01220 |=C2=A0=C2=A0 font_options =3D NULL; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 ^~~~~~~~~~~~ >=20 > This happens due to the fact that: `font_options' is declared in > L.231 which is guarded by > #ifdef HAVE_GSETTINGS > in L.209. >=20 > This was problem was most likely introduced with: >=20 > commit 526e9758de7d163ce3b25fde69a4e122ce9c3742 > Author: Pieter van Prooijen > Date:=C2=A0=C2=A0 Sun May 8 16:27:38 2022 +0200 >=20 > =C2=A0=C2=A0=C2=A0 Use gsettings font rendering entries for pgtk builds >=20 > cheers, > sascha