unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
To: Andrea Corallo <acorallo@gnu.org>, Eli Zaretskii <eliz@gnu.org>
Cc: acm@muc.de, yandros@gmail.com, emacs-devel@gnu.org,
	Po Lu <luangruo@yahoo.com>
Subject: Re: make check produces 25 failures and hangs (bug #65176).
Date: Sun, 13 Aug 2023 12:59:26 +0200	[thread overview]
Message-ID: <7f5635a2-c2bc-b90b-35b9-7c6a07822dae@vodafonemail.de> (raw)
In-Reply-To: <yp14jl4cc27.fsf@fencepost.gnu.org>

On 2023-08-12  21:09, Andrea Corallo wrote:

> To a very quick look seems to me `comp-subr-trampoline-install' is just
> not called as it should.  AFAIR it should be called from Ffset, I'm
> really wondering what could have happened.

Probably because native-comp-enable-subr-trampolines equals nil in an
"emacs-master -Q"?

When I compare the following snippet from emacs-master/lisp/loadup.el:

         (when (and (featurep 'native-compile)
                    (equal dump-mode "pdump"))
           ;; Don't enable this before bootstrap is completed, as the
           ;; compiler infrastructure may not be usable yet.
           (setq comp-enable-subr-trampolines t))
                 ^^^^

to emacs-29:

       (when (and (featurep 'native-compile)
                  (equal dump-mode "pdump"))
         ;; Don't enable this before bootstrap is completed, as the
         ;; compiler infrastructure may not be usable yet.
         (setq native-comp-enable-subr-trampolines t))
               ^^^^^^^^^^^

it seems that the android merge seems to be the culprit.  But leaving
that to others to judge.

In any case, fixing that setq in emacs-master to refer to
`native-comp-enable-subr-trampolines' again fixes the issue, at least
as far as my "little repro case" is concerned ... running "make check" 
... yep, no more hangs at least on abbrevs-test.el.




  reply	other threads:[~2023-08-13 10:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-10 19:18 make check produces 25 failures and hangs (bug #65176) Alan Mackenzie
2023-08-10 19:54 ` chad
2023-08-10 20:14   ` Alan Mackenzie
2023-08-10 20:34     ` Alan Mackenzie
2023-08-10 21:54       ` Jens Schmidt
2023-08-11  5:37         ` Eli Zaretskii
2023-08-11 19:39           ` Jens Schmidt
2023-08-12  0:10             ` Po Lu
2023-08-12  9:30               ` Jens Schmidt
2023-08-12 18:03           ` Andrea Corallo
2023-08-12 19:09             ` Andrea Corallo
2023-08-13 10:59               ` Jens Schmidt [this message]
2023-08-13 11:34                 ` Alan Mackenzie
2023-08-13 12:07                 ` Eli Zaretskii
2023-08-14  7:51                   ` Andrea Corallo
2023-08-14 12:07                     ` Eli Zaretskii
2023-08-14 13:38                       ` Andrea Corallo
2023-08-14 13:44                         ` Eli Zaretskii
2023-08-14 14:13                           ` Andrea Corallo
2023-08-14 14:52                         ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f5635a2-c2bc-b90b-35b9-7c6a07822dae@vodafonemail.de \
    --to=jschmidt4gnu@vodafonemail.de \
    --cc=acm@muc.de \
    --cc=acorallo@gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=yandros@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).