From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: Proposal for an improved `help-for-help' Date: Sat, 24 Apr 2021 17:18:42 +0000 Message-ID: <7ee648e840490fd32be8@heytings.org> References: <838s7hxqkr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11554"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 24 19:20:33 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1laLxI-0002s9-Fp for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Apr 2021 19:20:32 +0200 Original-Received: from localhost ([::1]:58888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1laLxH-0008TD-Gk for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Apr 2021 13:20:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laLvf-00080j-4Q for emacs-devel@gnu.org; Sat, 24 Apr 2021 13:18:51 -0400 Original-Received: from heytings.org ([95.142.160.155]:55380) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laLvZ-00084T-01 for emacs-devel@gnu.org; Sat, 24 Apr 2021 13:18:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1619284722; bh=IHljEf2FFubh6BHGJp/qdSM3F3c+8788RvzbWm/caUw=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=cm+mJ6ybCHjWj6EcJcN1H6fPtCeKESeQ3t8pqCPGke+Bj8PB2ISsW38TiVqWpDkfI 0l/AvwC0WGQcibJLk/nxCbBx/LYT/08dnkRmQ5eU3wwt++RSBrrns5ku0H8503D86Y o/XAXKqzn0SZiea8/njfYEi8nsdBFueQBeBF1oSdZ3iWbRTc6QP7HVi8hrlG1gqojA 7AB6wQnOrP9NnDfOt6IXKbWLaNJQyko/rcfU3fa6ncGTmSlYN1jVgC7PUIUI81x5i5 ZnqkQGPTNdwFCDF8Il1rVWuCS9lKoGlm5b2elJ1ibIHO+OPT6FEfIpVerVpNRNaLO8 Kh2hB1LgIWYwA== In-Reply-To: Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268338 Archived-At: > > That was 2 weeks ago. Based on the feedback I received at the time, I > have now pushed my final version of this patch to master. > > There is of course still time for further tweaks before Emacs 28. I > invite anyone to report bugs in case they can see any opportunities for > improving this. (Feel free to CC me if you do as I'm currently not > subscribed to the bug list.) > > Thank you to everyone who contributed to the discussion! > Thank you, this is very nice! A small possible improvement, which I hadn't seen earlier: "Show last 300 input keystrokes" could be improved I think, it's a configurable option. So I would either remove the constant "300" (if the precise size of the lossage is not important enough to be indicated there), or by using the return value of (lossage-size). Another small possible improvement: add a "\n" at the end of the list, so that the cursor does not jump to the end of the line when you reach the last item.