From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>
Cc: William Xu <william.xwl@gmail.com>, emacs-devel@gnu.org
Subject: Re: Xref completion
Date: Sat, 5 Dec 2020 03:12:43 +0200 [thread overview]
Message-ID: <7e7e6923-851f-c1c0-4816-d84debe6570b@yandex.ru> (raw)
In-Reply-To: <87pn3q8ulz.fsf@mail.linkov.net>
On 03.12.2020 23:09, Juri Linkov wrote:
>>> BTW, like you created xref--show-defs-minibuffer
>>> as a possible option for xref-show-definitions-function,
>>> wouldn't it be also nice to do the same and create
>>> xref--show-xref-minibuffer as a possible option for
>>> xref-show-xrefs-function?
>>
>> Don't you usually want to iterate across multiple results, when the command
>> is project-find-regexp or xref-find-references? Then the same logic will
>> not work.
>
> Right, xref--show-xref-minibuffer would be not as useful as
> xref--show-defs-minibuffer is. Hope to see xref--show-defs-minibuffer
> in xref.el soon.
I've pushed it now with some changes, hope you all like the result.
Shortening the group part (in most common cases) is among them.
Also added some highlighting with corresponding xref faces. It now looks
closer to Pierre's original screenshot.
Removed the bit of logic that hid the summaries when they are
technically unnecessary because in my testing it made completion
slightly less useful by hiding information (sorry). Anybody who really
preferred the previous version, please try it again with c86dc8d488
reverted locally, and maybe propose a user option for that behavior.
BTW, Juri, how do you think this new function compares against
xref--show-defs-buffer-at-bottom?
On the one hand, it feels kinda faster, on the other, it lacks the
ability to "look around" when you really need it. In an ideal world, I
guess the UI would be somewhere in the middle.
next prev parent reply other threads:[~2020-12-05 1:12 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 18:13 Xref completion Pierre Neidhardt
2020-11-17 18:22 ` [SPAM UNSURE] " Stephen Leake
2020-11-17 18:32 ` Pierre Neidhardt
2020-11-17 18:46 ` Basil L. Contovounesios
2020-11-17 18:38 ` Eli Zaretskii
2020-11-17 19:11 ` Pierre Neidhardt
2020-11-17 19:27 ` Juri Linkov
2020-11-17 20:00 ` Dmitry Gutov
2020-11-17 21:16 ` William Xu
2020-11-17 21:38 ` Dmitry Gutov
2020-11-18 7:35 ` William Xu
2020-11-18 13:46 ` Dmitry Gutov
2020-11-18 18:53 ` William Xu
2020-11-18 19:22 ` Dmitry Gutov
2020-11-18 20:39 ` Juri Linkov
2020-11-19 1:34 ` Dmitry Gutov
2020-11-18 18:47 ` João Távora
2020-11-19 1:43 ` Dmitry Gutov
2020-11-19 8:19 ` William Xu
2020-11-19 13:30 ` Dmitry Gutov
2020-12-02 21:44 ` Juri Linkov
2020-12-03 0:25 ` Dmitry Gutov
2020-12-03 21:09 ` Juri Linkov
2020-12-05 1:12 ` Dmitry Gutov [this message]
2020-12-05 12:21 ` William Xu
2020-12-05 21:02 ` Dmitry Gutov
2020-12-06 8:30 ` William Xu
2020-12-06 11:00 ` Dmitry Gutov
2020-12-06 14:00 ` William Xu
2020-12-06 21:01 ` Dmitry Gutov
2020-12-05 19:52 ` Juri Linkov
2020-12-05 21:44 ` Dmitry Gutov
2020-12-06 20:46 ` Juri Linkov
2020-12-06 21:20 ` Dmitry Gutov
2020-12-06 21:34 ` Juri Linkov
2020-12-06 21:40 ` Dmitry Gutov
2020-12-07 9:27 ` Daniel Martín
2020-12-07 15:12 ` jixiuf
2020-12-07 21:57 ` Dmitry Gutov
2020-12-07 21:53 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e7e6923-851f-c1c0-4816-d84debe6570b@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
--cc=william.xwl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).