From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: Unbalanced change hooks (part 2) [Documentation fix still remaining] Date: Sun, 28 Aug 2016 15:16:51 -0700 Message-ID: <7e1478b6-cf00-fcbf-8c24-43bdaa57e2b6@dancol.org> References: <83inv9hkjd.fsf@gnu.org> <83h9ashfgx.fsf@gnu.org> <831t1wharr.fsf@gnu.org> <20160810161821.GB3413@acm.fritz.box> <83wpjofttf.fsf@gnu.org> <20160810185735.GD3413@acm.fritz.box> <20160811112951.GA2154@acm.fritz.box> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1472422796 28590 195.159.176.226 (28 Aug 2016 22:19:56 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 28 Aug 2016 22:19:56 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 29 00:19:52 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1be8Qh-0006m8-8U for ged-emacs-devel@m.gmane.org; Mon, 29 Aug 2016 00:19:51 +0200 Original-Received: from localhost ([::1]:41043 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1be8Qe-000280-Pc for ged-emacs-devel@m.gmane.org; Sun, 28 Aug 2016 18:19:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50581) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1be8Q4-00027u-TP for emacs-devel@gnu.org; Sun, 28 Aug 2016 18:19:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1be8Py-00042F-VQ for emacs-devel@gnu.org; Sun, 28 Aug 2016 18:19:11 -0400 Original-Received: from dancol.org ([96.126.100.184]:51362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1be8Py-00041v-Mk for emacs-devel@gnu.org; Sun, 28 Aug 2016 18:19:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject; bh=l6NIV3gksOIPAds5NsNwRD35CacDrciNd8eYEmGqnOk=; b=qBuky3dLNxTHXNCgUNLJy7uEA/pOKRHRd37vFoROJF6ZfmMYIqkMAdMTlw6JNVaa+0Hk4TPLTq1W1vE9aa5I8ppz6Fo3L21PynWXhlci9W0aEfoEM14frFkmx84YozUOInWlOBhlTTviZ2p8RIuibN1MnoD0Q81qN4yUbRSsn4M1RSo2/Bj16rQQHbVS53e7NgJ+s8VZsiOfisL8Pe1V7gKah5I3sIg28Q6/GbcMmBl4C1iDsEKhsBeCAr/goyZgcSFwPagQ1Gej9wgakQ/Hmkclo9MYYubeoqWLV2RkyjGWL9JZ5brr5bjOpQ3yoFXe6fPUaQR75Yxj/AgLbGj5DA==; Original-Received: from c-73-97-199-232.hsd1.wa.comcast.net ([73.97.199.232] helo=[192.168.1.173]) by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1be8Nr-0006dD-W6; Sun, 28 Aug 2016 15:16:56 -0700 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 96.126.100.184 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206847 Archived-At: On 08/28/2016 08:01 AM, Stefan Monnier wrote: >> Besides, you haven't fixed the docstring, which still suggests that b-c-f is >> called before every change. (And a "change" must be anything that results in >> a-c-f being called.) > > It doesn't just suggest it, it says so, and rightly so. So will insdel.c or the docstring change? FWIW, there *is* a certain elegance to the idea of the "forget everything after the first bit that changed" model of change tracking, but as long as b-c-f exists, it might as well work consistently.