From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Mathias Dahl" Newsgroups: gmane.emacs.devel Subject: Re: Small change in image-dired.el Date: Sun, 30 Mar 2008 01:55:43 +0100 Message-ID: <7dbe73ed0803291755j6d7a3a06l8ac07282fd608961@mail.gmail.com> References: <7dbe73ed0803291308o2c127601k6ceeb3351d3a1f83@mail.gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1206838561 31866 80.91.229.12 (30 Mar 2008 00:56:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 30 Mar 2008 00:56:01 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Stefan Monnier" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 30 01:56:32 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JflqV-0008GU-Pr for ged-emacs-devel@m.gmane.org; Sun, 30 Mar 2008 01:56:28 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jflpu-0000mX-Au for ged-emacs-devel@m.gmane.org; Sat, 29 Mar 2008 20:55:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jflpq-0000l5-5r for emacs-devel@gnu.org; Sat, 29 Mar 2008 20:55:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jflpp-0000kI-BL for emacs-devel@gnu.org; Sat, 29 Mar 2008 20:55:45 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jflpo-0000k9-UQ for emacs-devel@gnu.org; Sat, 29 Mar 2008 20:55:44 -0400 Original-Received: from wf-out-1314.google.com ([209.85.200.173]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jflpo-0000yW-LG for emacs-devel@gnu.org; Sat, 29 Mar 2008 20:55:44 -0400 Original-Received: by wf-out-1314.google.com with SMTP id 29so865193wff.24 for ; Sat, 29 Mar 2008 17:55:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=0DO2S4jBSmmJiicIYmXVvz473vw01phZiNWnMuec214=; b=TaaqZQHlNNH+yeJtpyEodjRg8z0ELEdmQFJqx7NKlIG+onQGO9Z4wmuw2ZV3E01G1KiXkyZNP7J/9eksQ9LaHE/FCIWHE49P062bI//tF88AvZ2bybBz/LHblLC28awduUVj1wQoi697MxLozKaowcEgSBgbmHMH/deEvy1+o/E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=WoCkYY/ypNr23GDvhXVYI9rnACryq2MOaeDB0ksYtU6vY5o2qjgkzokrDEnZ/JvyRXXFics1HBrRhyUrB3dBCfIvQXMmzRT+YsjzqEB92E1b3lQAcEW9P0pxj+NpRVEsH1yyEWQFzb/Ka6t1sF2C1BsGavhBYweJeBhzIGH3DnI= Original-Received: by 10.114.197.1 with SMTP id u1mr6959718waf.61.1206838543450; Sat, 29 Mar 2008 17:55:43 -0700 (PDT) Original-Received: by 10.114.146.9 with HTTP; Sat, 29 Mar 2008 17:55:43 -0700 (PDT) In-Reply-To: Content-Disposition: inline X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:93847 Archived-At: > What is the rationale for such a "feature"? See below. > Generally, modifying a file > and then changing its timestamp back to what it was is a good way to get > in trouble (many programs assume that if the timestamp hasn't changed, > then the file hasn't changed). Yes, I agree, mostly. > I'm not necessarily opposed to it, but I'd first like a compelling > evidence that this is really the right way to solve the > original problem. I think the only "problem" was that Stefan R was used to work in a certain way with his photos, and the rotation messed up with his scheme. I suspect for him that a rotation is an operation that can be neglected from a change viewpoint. Here is our original conversation: ---- from=09Stefan Reich=F6r to=09Mathias Dahl date=09Sat, Jun 17, 2006 at 10:31 PM subject=09Improvement for tumme-rotate-original mailed-by=09utanet.at =09=09 Hi Mathias! I try to use tumme to organize/view my photo collection. My photos all keep the timestamp when they were shot. I modified tumme-rotate-original in a way that the time stamp is preserved. It would be nice, if you could add this functionality! Stefan. [patch removed] from=09Mathias Dahl to=09Stefan Reich=F6r date=09Sun, Jun 18, 2006 at 8:53 AM subject=09Re: Improvement for tumme-rotate-original mailed-by=09gmail.com =09 Thanks for the patch, I'll think about it. Personally I never trust the timestamp of a file because I have found out too many times that it has been modified in transit, when copying, moving, FTPing, zipping, whatever... What I do instead is trust the EXIF data in it, make sure that it is always preserved (tumme does that by default). I also rename all the photos I take with my camera using the internal timestamp so that the names will be unique and sorted in the correct order in dired etc. Tumme has a command for this, `tumme-copy-with-exif-file-name'. Maybe that is something you would like to try? Also, the touch command is not available on w32 so this would have to be an option or we would have to find a suitable replacement command that works there. I suggest you keep your fix in your .emacs and I *might* try merge it into tumme.el when I have the time. Again, thanks for the suggestion! from=09Stefan Reich=F6r to=09Mathias Dahl date=09Mon, Jun 19, 2006 at 6:23 AM subject=09Re: Improvement for tumme-rotate-original =09 Hi Mathias! > Thanks for the patch, I'll think about it. Personally I never trust > the timestamp of a file because I have found out too many times that > it has been modified in transit, when copying, moving, FTPing, > zipping, whatever... What I do instead is trust the EXIF data in it, > make sure that it is always preserved (tumme does that by default). I > also rename all the photos I take with my camera using the internal > timestamp so that the names will be unique and sorted in the correct > order in dired etc. Tumme has a command for this, > `tumme-copy-with-exif-file-name'. Maybe that is something you would > like to try? Thanks for your ideas. I try to keep the date correct for my pictures. And that works for me. Thanks for the hint about the EXIF data. I also have a small python script to rename my pictures, using the date. It is nice to see that date on the back of the pictures when I order them from a photo shop. > Also, the touch command is not available on w32 so this would have to > be an option or we would have to find a suitable replacement command > that works there. You could try, if touch is available and use it only then. Something like tumme-has-touch-command. > I suggest you keep your fix in your .emacs and I *might* try merge it > into tumme.el when I have the time. That is fine with me. I think most users will prefer this behaviour. ---- As you can see, I too think EXIF should be trusted rather than the timestamp. Still, I thought the feature sounded OK to have and should not hurt anything, especially with the new variable introduced. Granted, even if the change is quite small, it increases comple= xity, so I won't argue about it being included. /Mathias