tumme and keyboard macros.

tumme and keyboard macros.

[Matt Hodges]

It might be useful for tumme-forward-char and tumme-backward-char
(perhaps tumme-{forward/backward}-image would be better names?) to
signal an error from the last and first thumbnails respectively.  This
would make useful `C-u 0 C-x e' type execution of keyboard macros in
*tumme* buffers.

(Support for prefix args would be good for all the movement commands.)

Thanks,

Matt

Re: tumme and keyboard macros.

[Mathias Dahl]

> It might be useful for tumme-forward-char and tumme-backward-char
> (perhaps tumme-{forward/backward}-image would be better names?)

Yes, those might be better names.

> to
> signal an error from the last and first thumbnails respectively.  This
> would make useful `C-u 0 C-x e' type execution of keyboard macros in
> *tumme* buffers.

I don't see how such a keyboard macro would be useful; can you
explain? If you want to have a way to move to the beginning and end of
the tumme buffer, maybe it's better to add such commands instead? Or
we could do both.

> (Support for prefix args would be good for all the movement commands.)

Personally I seldom or never use prefix args for the movement commands
in Emacs, but as they are so many commends that does support it, I
guess people would find such an addition useful.

Re: tumme and keyboard macros.

[Mathias Dahl]

> > signal an error from the last and first thumbnails respectively.  This
> > would make useful `C-u 0 C-x e' type execution of keyboard macros in
> > *tumme* buffers.
>
> I don't see how such a keyboard macro would be useful; can you
> explain? If you want to have a way to move to the beginning and end of
> the tumme buffer, maybe it's better to add such commands instead? Or
> we could do both.

Sorry for that, I read your e-mail to quickly. I though the macro
would only consist of `tumme-forward-char' or `tumme-backward-char'
but of course they can be more complex than that and do whatever cool
stuff you want to do. I will think about this.

Re: tumme and keyboard macros.

[Mathias Dahl]

> It might be useful for tumme-forward-char and tumme-backward-char
> (perhaps tumme-{forward/backward}-image would be better names?) to
> signal an error from the last and first thumbnails respectively.  This
> would make useful `C-u 0 C-x e' type execution of keyboard macros in
> *tumme* buffers.
>
> (Support for prefix args would be good for all the movement commands.)

I just commited a rename of those commands. Also, below is a new
version of `tumme-forward-image' with the changes you asked for.
Please try it out:

(defun tumme-forward-image (&optional arg)
  "Move to next image and display properties.
Optional prefix ARG says how many images to move; default is one
image."
  (interactive "p")
  (let (pos (steps (or arg 1)))
    (dotimes (i steps)
      (if (save-excursion
            (forward-char)
            (while (and (not (eobp))
                        (not (tumme-image-at-point-p)))
              (forward-char))
            (setq pos (point))
            (tumme-image-at-point-p))
          (goto-char pos)
        (error "No more images"))))
  (when tumme-track-movement
    (tumme-track-original-file))
  (tumme-display-thumb-properties))

/Mathias

Re: tumme and keyboard macros.

[Matt Hodges]

>>>>> Mathias Dahl writes:

 > Sorry for that, I read your e-mail to quickly. I though the macro
 > would only consist of `tumme-forward-char' or `tumme-backward-char'
 > but of course they can be more complex than that and do whatever
 > cool stuff you want to do. I will think about this.

Yes, that was what I had in mind.  Thanks.

Re: tumme and keyboard macros.

[Matt Hodges]

>>>>> Mathias Dahl writes:

 > I just commited a rename of those commands. Also, below is a new
 > version of `tumme-forward-image' with the changes you asked for.
 > Please try it out:

Works for me.  Thanks.

Matt

Re: tumme and keyboard macros.

[Mathias Dahl]

>  > I just commited a rename of those commands. Also, below is a new
>  > version of `tumme-forward-image' with the changes you asked for.
>  > Please try it out:
>
> Works for me.  Thanks.

I commited this and also a new version of `tumme-backward-image' with
similar changes.

/Mathias