unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>,
	Daniel Mendler <mail@daniel-mendler.de>,
	"Jens C. Jensen" <jens@subst.net>
Cc: emacs-devel@gnu.org
Subject: Re: master d4ae640: * lisp/help-fns.el (help--symbol-class): New function.
Date: Fri, 4 Jun 2021 00:01:48 +0300	[thread overview]
Message-ID: <7dba60d3-832a-3574-32b2-1d138669faf2@yandex.ru> (raw)
In-Reply-To: <87a6o6zn7k.fsf@mail.linkov.net>

On 03.06.2021 23:51, Juri Linkov wrote:
>>> +(defun help--symbol-class (s)
>>> +  "Return symbol class characters for symbol S."
>>> +  (when (stringp s)
>>> +    (setq s (intern-soft s)))
>>> +  (cond ((commandp s)
>>> +         "c")                           ; command
>>> +        ((eq (car-safe (symbol-function s)) 'macro)
>>> +         "m")                           ; macro
>>> +        ((fboundp s)
>>> +         "f")                           ; function
>>> +        ((custom-variable-p s)
>>> +         "u")                           ; user option
>>> +        ((boundp s)
>>> +         "v")                           ; variable
>>> +        ((facep s)
>>> +         "a")                           ; fAce
>>> +        ((and (fboundp 'cl-find-class)
>>> +              (cl-find-class s))
>>> +         "t")                           ; CL type
>>> +        (" ")                           ; something else
>>> +        ))
>> Looks awfully similar to elisp--company-kind.
> Feel free to improve it, taking into account wishes expressed by
> Daniel and Jens.

I think it calls for more design discussion up front, to satisfy all 
parties.



      reply	other threads:[~2021-06-03 21:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210603204158.4014.59130@vcs0.savannah.gnu.org>
     [not found] ` <20210603204159.B8F88209AA@vcs0.savannah.gnu.org>
2021-06-03 20:45   ` master d4ae640: * lisp/help-fns.el (help--symbol-class): New function Dmitry Gutov
2021-06-03 20:51     ` Juri Linkov
2021-06-03 21:01       ` Dmitry Gutov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7dba60d3-832a-3574-32b2-1d138669faf2@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=jens@subst.net \
    --cc=juri@linkov.net \
    --cc=mail@daniel-mendler.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).