unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Lina Bhaile" <emacs-devel@linabee.uk>
To: emacs-devel@gnu.org
Subject: Eglot rename, create, delete support
Date: Mon, 04 Mar 2024 19:18:36 +0000	[thread overview]
Message-ID: <7d6032f1-33e3-41aa-82b7-5b1b032bf0e1@app.fastmail.com> (raw)

(Resending due to wrong From:)

Hi all,

The Language Server Protocol spec allows for servers to send requests to the
client (in this case Emacs/Eglot) to create, rename or delete files in the
project if the client advertises that it can do “resourceOperations”
[https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#resourceChanges].
Unfortunately Eglot does not support this in either HEAD or in Emacs 29. It’s
particularly useful for Java since the compiler for that language refuses to
compile a file if the name of a type does not match the file name, as well as
code actions for moving types from one package (namespace) to another.

I have a patch that adds support for rename requests to Eglot inside an
extension package for connecting to a Java language server, but it is very
hacky because it needs to advise eglot--apply-workspace-edit which will
mishandle parsing if it encounters an object with a different type than
TextDocumentEdit inside a workspace edit response
[https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspaceEdit].
Really, though, this code should be inside Eglot itself. I would share it on
the list but I do not have my copyright assigned yet, it's pushing around 125
lines with just rename support. As well I would like some review and to write
some tests as these are potentially destructive operations and I would like to
handle all the potential corner cases that might arise.

If someone could send me the copyright assignment forms that would be grand.

   	   Lina



             reply	other threads:[~2024-03-04 19:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-04 19:18 Lina Bhaile [this message]
2024-03-04 20:14 ` Eglot rename, create, delete support Eli Zaretskii
  -- strict thread matches above, loose matches on Subject: below --
2024-03-04 18:00 me
2024-09-22 11:46 ` Stefan Kangas
     [not found] ` <CADwFkmnjtKog0Pr7Bzs6V80NBJp4Q2i2-uMWGy0v8B76DfH=Tw@mail.gmail.com>
2024-09-26 10:14   ` emacs-devel
2024-09-26 13:20     ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d6032f1-33e3-41aa-82b7-5b1b032bf0e1@app.fastmail.com \
    --to=emacs-devel@linabee.uk \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).