From: Dmitry Gutov <dgutov@yandex.ru>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 305dbc7 2/4: Move description of value to syntax-ppss function.
Date: Wed, 30 Oct 2019 17:26:19 +0200 [thread overview]
Message-ID: <7d102a3b-3a3e-b83f-038d-6edec9a1f49a@yandex.ru> (raw)
In-Reply-To: <87a79itfzp.fsf@gnus.org>
On 30.10.2019 17:22, Lars Ingebrigtsen wrote:
> Yes, the doc string certainly implies that they can be relied upon if
> you use that function instead.
>
> On the other hand, perhaps I shouldn't have moved it --
> parse-partial-sexp is used a lot, too. I was only seeing syntax-ppss
> everywhere, but I see that it's used less than 2x as much.
syntax-ppss is indeed the function that most consumers should call, but
it's low-level enough that I never considered that to be a problem.
> So perhaps that patch should be reverted anyway.
That's what I would do.
> Or have the list in
> both functions. Or, even better, stop saying
>
> (if (nth 5 state)
> (do-something-incomprehensible)
> (do-something-else-incomprehensible))
>
> everywhere and just add accessor functions already, so that the code
> becomes marginally more readable. Because trying to make sense of it
> now is just too hard, and it doesn't have to be.
Someone should probably try to add that accessor thing, but also
perf-test the result.
next prev parent reply other threads:[~2019-10-30 15:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191030121649.15369.13207@vcs0.savannah.gnu.org>
[not found] ` <20191030121651.BFCF8204DF@vcs0.savannah.gnu.org>
2019-10-30 14:59 ` master 305dbc7 2/4: Move description of value to syntax-ppss function Dmitry Gutov
2019-10-30 15:03 ` Lars Ingebrigtsen
2019-10-30 15:13 ` Dmitry Gutov
2019-10-30 15:22 ` Lars Ingebrigtsen
2019-10-30 15:26 ` Dmitry Gutov [this message]
2019-10-30 15:30 ` Lars Ingebrigtsen
2019-10-30 15:29 ` Lars Ingebrigtsen
2019-10-30 16:13 ` Dmitry Gutov
2019-10-30 16:17 ` Lars Ingebrigtsen
2019-10-30 16:47 ` Dmitry Gutov
2019-10-30 17:03 ` Lars Ingebrigtsen
2019-10-30 19:39 ` Stefan Monnier
2019-10-30 20:28 ` Lars Ingebrigtsen
2019-12-13 12:34 ` Noam Postavsky
2019-12-13 13:03 ` Dmitry Gutov
2019-12-17 16:28 ` Lars Ingebrigtsen
2020-02-15 14:55 ` Noam Postavsky
2020-02-15 15:14 ` Dmitry Gutov
2020-02-15 16:23 ` Noam Postavsky
2020-02-23 14:11 ` Noam Postavsky
2019-10-30 20:34 ` Alan Mackenzie
2019-10-30 20:41 ` Dmitry Gutov
2019-10-31 1:45 ` Stefan Monnier
2019-10-31 14:06 ` Lars Ingebrigtsen
2019-10-30 20:47 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d102a3b-3a3e-b83f-038d-6edec9a1f49a@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).