From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Matthias Dahl Newsgroups: gmane.emacs.devel Subject: Re: wait_reading_process_ouput hangs in certain cases (w/ patches) Date: Wed, 14 Mar 2018 10:56:33 +0100 Message-ID: <7b64afc3-e9b0-536d-1e42-a5f5d74f1adf@binary-island.eu> References: <206ebefa-7583-f049-140c-c8fd041b0719@cs.ucla.edu> <709614e8-1937-07c1-f554-b453ed4f3d4a@binary-island.eu> <7550438b-9fd4-d374-e571-8bb16456cad5@cs.ucla.edu> <797d0e16-1bae-50c2-35f8-05489ffce935@binary-island.eu> <83tvugdiu5.fsf@gnu.org> <877er5s0xv.fsf@gmail.com> <4e4c72bb-295d-81e1-e4ed-cad256bca83c@binary-island.eu> <87zi3v9461.fsf@gmail.com> <87k1uy8x68.fsf@gmail.com> <6d1970af-8c5c-20ba-be09-0b9aa757d663@binary-island.eu> <13b3e003-d12b-33a7-3ebe-c07b017a7cc0@binary-island.eu> <833714rm3d.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1521021332 14931 195.159.176.226 (14 Mar 2018 09:55:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 14 Mar 2018 09:55:32 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 Cc: larsi@gnus.org, rrandresf@gmail.com, emacs-devel@gnu.org, eggert@cs.ucla.edu To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 14 10:55:27 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ew383-0003eK-3n for ged-emacs-devel@m.gmane.org; Wed, 14 Mar 2018 10:55:27 +0100 Original-Received: from localhost ([::1]:45178 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ew3A4-0005Cv-6X for ged-emacs-devel@m.gmane.org; Wed, 14 Mar 2018 05:57:32 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ew39u-0005C5-TR for emacs-devel@gnu.org; Wed, 14 Mar 2018 05:57:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ew39D-0007xg-Nb for emacs-devel@gnu.org; Wed, 14 Mar 2018 05:57:22 -0400 Original-Received: from ud19.udmedia.de ([194.117.254.59]:38472 helo=mail.ud19.udmedia.de) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ew39C-0007ug-Di for emacs-devel@gnu.org; Wed, 14 Mar 2018 05:56:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=binary-island.eu; h= subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=k1; bh=Kk 6+3rNDxiDBunPs+9BhzV2qbue7bYB8NJFJL0a/w4I=; b=Njd0RBj4WNCtI9/1fo LKzScigtlWK9h7nLVedocTtgpLwItnGe+gq+wkA0/w5UO0NI/20S+c5Af98gWEAk xEmR6Tpp4MECxwodpJrs8uHxcsHhBSBCikHBf/x7f5FeFoTtkDiONOotPtmt6usu 9nt56o08cIoMgZXdECAPkYXaU= Original-Received: (qmail 14625 invoked from network); 14 Mar 2018 10:56:34 +0100 Original-Received: from unknown (HELO ?IPv6:2a02:810b:c540:234:36aa:25b9:ca8f:d05f?) (ud19?126p1@2a02:810b:c540:234:36aa:25b9:ca8f:d05f) by mail.ud19.udmedia.de with ESMTPSA (ECDHE-RSA-AES128-GCM-SHA256 encrypted, authenticated); 14 Mar 2018 10:56:34 +0100 Openpgp: id=1E87ADA02EFE759EFC20B2D1042F47D273AA780C In-Reply-To: <833714rm3d.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 194.117.254.59 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223716 Archived-At: Hello Eli... On 13/03/18 17:12, Eli Zaretskii wrote: > I don't think it makes sense to put this on the emacs-26 branch, > sorry. I even have evidence: the fact that one of the hunks > re-introduced a previously solved bug, as pointed out by Robert. > > This code is very delicate and very central to Emacs operation. It's > very easy to break Emacs subtly by seemingly-innocent changes in that > area. We really need to test it much more than a few weeks before we > are confident enough it is bug-free. The master branch is where such > changes should be tested. Normally I would fully agree. But we are not talking about new features here but fixes to bugs that cause sporadic and hard to pinpoint erratic behavior and hangs possibly all over the place. It is pure chance and the packages you have installed, if you run into those several times a day or really never. What I am trying to say: Is it really better to keep those bugs around for another year or more until master becomes the next stable release just based on the pure chance that we might (or might not) introduce breakage? Or should we commit the fixes now (and fix current/real bugs this way) while we're still in the beta cycle and deal with any fall-out now (which might not even be needed after all). Imho, the later is the right thing to do (famous last words :P). We can fix the fall-out, if any should happen. That's what beta release are for and it is better to fix that now instead of in a year's time or so and have users deal with those bugs until then. Those bugs are, as you put it, at the heart of Emacs. They should be fixed and dealt with. Regarding the regression pointed out by Robert: I'm sorry that happened. There were no comments or anything. :( Unfortunately, that fix was also merely a workaround that fixed only half of the problem. Even though it dealt with the read fds, the other fd sets were kept as-is which surely could have caused some hiccups later down in wait_reading_... . The fix posted yesterday fixes the actual root cause, so on the bright side, it was a happy accident after all. ;-) Thanks for your patience with my arguing on this subject. In want to point out, I only have the user's best interests at heart and what ever you decide is fine by me. No offense meant or whatever. :) Have a nice day, Matthias -- Dipl.-Inf. (FH) Matthias Dahl | Software Engineer | binary-island.eu