* js.el: Correct highlighting of JS "dictionary keys"?
@ 2010-02-19 13:15 Deniz Dogan
2010-02-20 3:38 ` Daniel Colascione
0 siblings, 1 reply; 2+ messages in thread
From: Deniz Dogan @ 2010-02-19 13:15 UTC (permalink / raw
To: Emacs-Devel devel
The font locking in js.el has confused me a lot when it comes to JS
objects (or "dictionaries").
var dict = {
variable: 1,
callable: function () {
}
};
In this snippet "variable" gets the "default" face, whereas "callable"
gets "font-lock-function-name-face". To be consistent I'd like it if
one of the following changes are made:
1. "variable" gets "font-lock-variable-name-face" or some other
non-default face.
2. Both "variable" and "callable" gets a new JS-specific face which
give them both the same look. (My personal preference.)
I'd supply a patch if my elisp-fu was better. Any thoughts on this?
--
Deniz Dogan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: js.el: Correct highlighting of JS "dictionary keys"?
2010-02-19 13:15 js.el: Correct highlighting of JS "dictionary keys"? Deniz Dogan
@ 2010-02-20 3:38 ` Daniel Colascione
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Colascione @ 2010-02-20 3:38 UTC (permalink / raw
To: Deniz Dogan; +Cc: Emacs development discussions
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 2/19/10 8:15 AM, Deniz Dogan wrote:
> I'd supply a patch if my elisp-fu was better. Any thoughts on this?
>
I will work on this.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (Darwin)
iEYEARECAAYFAkt/WRkACgkQ17c2LVA10VuncQCbBP3Ot5zrGPBDyukRep69MPD5
T6MAniITBZe1ecuvNQsrV79BaYdM61aW
=HOSE
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-20 3:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-19 13:15 js.el: Correct highlighting of JS "dictionary keys"? Deniz Dogan
2010-02-20 3:38 ` Daniel Colascione
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).