unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Deniz Dogan <deniz.a.m.dogan@gmail.com>
To: Emacs-Devel devel <emacs-devel@gnu.org>
Subject: js.el: Correct highlighting of JS "dictionary keys"?
Date: Fri, 19 Feb 2010 14:15:38 +0100	[thread overview]
Message-ID: <7b501d5c1002190515v6307b7a4v9163ed42696584f7@mail.gmail.com> (raw)

The font locking in js.el has confused me a lot when it comes to JS
objects (or "dictionaries").

var dict = {
    variable: 1,
    callable: function () {
    }
};

In this snippet "variable" gets the "default" face, whereas "callable"
gets "font-lock-function-name-face". To be consistent I'd like it if
one of the following changes are made:

1. "variable" gets "font-lock-variable-name-face" or some other
non-default face.
2. Both "variable" and "callable" gets a new JS-specific face which
give them both the same look. (My personal preference.)

I'd supply a patch if my elisp-fu was better. Any thoughts on this?

-- 
Deniz Dogan




             reply	other threads:[~2010-02-19 13:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-19 13:15 Deniz Dogan [this message]
2010-02-20  3:38 ` js.el: Correct highlighting of JS "dictionary keys"? Daniel Colascione

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b501d5c1002190515v6307b7a4v9163ed42696584f7@mail.gmail.com \
    --to=deniz.a.m.dogan@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).