From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Poll: Change xref-show-definitions-function's default? Date: Mon, 4 Jan 2021 20:41:52 +0200 Message-ID: <7b108ef2-7798-19b9-f37d-680bdcb23745@yandex.ru> References: <9af40a30-8964-3142-aadf-6592605720ec@yandex.ru> <871rf0ob2c.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11224"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: emacs-devel To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 04 19:44:31 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwUqF-0002nm-1w for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Jan 2021 19:44:31 +0100 Original-Received: from localhost ([::1]:45376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwUqE-0004KG-3t for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Jan 2021 13:44:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwUno-0003Ln-2x for emacs-devel@gnu.org; Mon, 04 Jan 2021 13:42:00 -0500 Original-Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]:46453) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwUnl-0004T8-Tn for emacs-devel@gnu.org; Mon, 04 Jan 2021 13:41:59 -0500 Original-Received: by mail-ej1-x636.google.com with SMTP id t16so8549467ejf.13 for ; Mon, 04 Jan 2021 10:41:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=x8w3/DtyRE5uaKR5upWQ4vtnHTSSKN67z5tVoVf0zhk=; b=Vh5nPhETSUEkDNA1bgPsZmR5gieWk8n+w91KSx9kddlzGdSB4tB6ohlSoNZAShxQgV twgKNkQY/HhVbziXihvzfJ9FPTNSNtuA3uNUN252nmxEmWgoaGRHuO5vbU9YhyGGcr51 L4UrFyNSNCnT81inQ0c8F4QSmOSF0ySvSur8Eje75sazd72qab0V0HAq9n8rF1SHx9zH p7NBhS2sQxhIq3A43ej9OKQUyFg0W5A6Zav7wKtMsL9+SxKl30S9xZJNgLCjXx3JQ9SH 3qMc/z835k517H7m0bRfd6ZlMrpj1lSTuLCKF3zRyOin81pUiWK6twPnhgtIQbaRHC6Q IU3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=x8w3/DtyRE5uaKR5upWQ4vtnHTSSKN67z5tVoVf0zhk=; b=JJUbdyFDPQuAoY6lwEeugMTHdPmPrA+XXnxguQROcVf2gQ46eqFr/nH+sc9kwnj3MG GBRYHZPCOj6lWdx58EoHe7wVZ488HT6d+MDamH98IgMZ79CdvnJRIy8wyF64xJPDGYia wf3Jy0aaSiFQRvtFrOrn8zQ3lkoCaQu3T83JXQZcAF5w7a1+ajTDsRBkNOMGPBBYNcmP O/CTfbJmrriE3G5vD4rE12UbKfMgvdxATmPrkAzOFjJOzssNpKlpPAuRtsvGYh2NWTW+ M7Rb6tvsscfPflpBQOLTeL3h6BoMi0Tv4O0Hqd/4ieRL29am6J/m8EEsOo7p/Buhj5Io pKVg== X-Gm-Message-State: AOAM531oXidvZozsoVAczKWQvSLpIxPQiyHZDHRnU+GkEaNL4xzAUaPX eO3rJo6d0csCWryGD1XguZ9S7rD0IhSLfw== X-Google-Smtp-Source: ABdhPJwWhbGSaDtbNIJDt3mTEjNgb0z5ov1wVNHgW8ngPNrn9kshPwp5gNlyno4iE5kHyIPEAj1Eug== X-Received: by 2002:a17:906:1288:: with SMTP id k8mr42107507ejb.206.1609785715474; Mon, 04 Jan 2021 10:41:55 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id w20sm44692865edi.12.2021.01.04.10.41.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Jan 2021 10:41:54 -0800 (PST) In-Reply-To: <871rf0ob2c.fsf@mail.linkov.net> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::636; envelope-from=raaahh@gmail.com; helo=mail-ej1-x636.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262476 Archived-At: On 04.01.2021 19:42, Juri Linkov wrote: >> In commit 8c383456291185b029b469061338b5b797a49747 I have done a bit of >> cleanup and documented the existing alternative options. >> >> What do you say we make one of them the default? > > As part of this poll we could also decide what to do with the TAB keybinding > because especially after changing the value of 'xref-show-definitions-function' > to 'xref-show-definitions-completing-read' and using the *xref* buffer > exclusively for the grep-like output, it makes more sense for > TAB to behave as in grep-mode. No need to poll about that, I think. As long as we change the default to one of the current two alternatives, TAB won't play any role in either (the -at-bottom function sets up RET to call the same command). Then we can safely remove/change the TAB binding in xref--xref-buffer-mode, or alternatively, create a new major mode that is slightly more Grep-like, and use it in the default xref-show-xrefs-function.