From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= Newsgroups: gmane.emacs.devel Subject: Re: pull requests Date: Fri, 27 Mar 2020 09:00:10 -0400 Message-ID: <7b0e82fd-8928-26d2-4bed-331593685f36@gmail.com> References: <87mu87ji39.fsf@dick> <87v9mvp2ms.fsf@blind.guru> <87d093f6lj.fsf@dick> <87369yc79r.fsf@dick> <83mu828c7d.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="90421"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 27 14:01:21 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jHobu-000NJ1-Mo for ged-emacs-devel@m.gmane-mx.org; Fri, 27 Mar 2020 14:01:18 +0100 Original-Received: from localhost ([::1]:41514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHobt-0006ua-OE for ged-emacs-devel@m.gmane-mx.org; Fri, 27 Mar 2020 09:01:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48204) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHoat-0006MJ-J6 for emacs-devel@gnu.org; Fri, 27 Mar 2020 09:00:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHoas-0001sv-Fz for emacs-devel@gnu.org; Fri, 27 Mar 2020 09:00:15 -0400 Original-Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]:40784) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jHoas-0001qM-Bg for emacs-devel@gnu.org; Fri, 27 Mar 2020 09:00:14 -0400 Original-Received: by mail-qt1-x831.google.com with SMTP id c9so8390879qtw.7 for ; Fri, 27 Mar 2020 06:00:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Oplha4GLX3HHpT6AXGifU0v1BXsK9as0+ndiidm8770=; b=QbPZApMipahOBldHmwsIMwwoTQQk02DXz0TN4FvLvSZ6D9B0GUx+Br+oyVLxwQOQVh uhoPGqaPwl222oFzP5jyY/OaDXh2Qe74TAY1wWPYSJDTvaSU5RkObbop0BWi4iOPGFHN k1j08Ong7q4xmbiiUAPK9O4P955aKRMWzeqoYhIjXIz5LPJ/Hl9cvTW2KFu1vS2FHYp4 ciAu8P4hXDKgrk3axtTTT1lIklItHnp1+WbUvP5DmmXEeRljbdScYtfJYXW9+PyEl8aI haeRsACGJvrXjfItz8Zb+q/sFvaOW3q3nZZ/vNmXFMLtR10S2Dq0Q32zvRpPD19fXyI4 S4bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Oplha4GLX3HHpT6AXGifU0v1BXsK9as0+ndiidm8770=; b=VAOgBr7FyoNHMH4eMkAxLS9+KcjjRYFZqg5rpWidZSb5ApAR9F6BUXYC6xToSsfdEE Kb9z5pc6zvbGXOhB/nTZscKOO1bnUtPGyoxuf6Op55plShaZ5jcKsvjQPJvaP1Tsxvqp 9sZVzhf86Rf805jmNgCt7YtD+ImI/vDapDiTjJck0/rEGzLHCWPr18bqOkWNkgCeCydv GTV7Zen7GwnU3oW0P96U0KvtetlwZeyZbWotZt63/HF5oSLhx9I5wfsuP7f5ZJsotIL4 rA1nboj6g9gmTXO0a85PhlDZEKqrt2wkwx1+J0Jkg1YMS+gLwxOXofz4vb7nHV4LF1u6 uQVw== X-Gm-Message-State: ANhLgQ24py1zH1kj/IcY0ShPEVXi7tgj+9LUM23KI9ErrHo4i78jqlRv Zp4ENKABs8NzDbYc0YNMcp01b2+I X-Google-Smtp-Source: ADFU+vv9YiO53RAoWNg7a8WUq/Fkm4gQE+wOFjkMIYkbTlJzNQyktlEYcMW4KchMbkDcgUeX62II3g== X-Received: by 2002:ac8:7316:: with SMTP id x22mr14306685qto.4.1585314013161; Fri, 27 Mar 2020 06:00:13 -0700 (PDT) Original-Received: from ?IPv6:2601:184:4180:66e7:b495:2869:edbc:3e2d? ([2601:184:4180:66e7:b495:2869:edbc:3e2d]) by smtp.googlemail.com with ESMTPSA id 4sm3695877qkl.51.2020.03.27.06.00.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Mar 2020 06:00:11 -0700 (PDT) In-Reply-To: <83mu828c7d.fsf@gnu.org> Content-Language: en-GB X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::831 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245836 Archived-At: On 27/03/2020 03.54, Eli Zaretskii wrote: > More importantly, given that I did a review > of such a remote branch, how do I communicate my comments so that they > are recorded for posterity? Probably by email, so that doesn't seem > to solve the main problem of avoiding email in the patch submission > and review workflow. Assuming you use the web UI, you can typically attach comments to code regions. Pros over email reviews include the fact that the comments remain attached to the code even after the patch is updated (so if the original author updates an unrelated section of the patch the comments don't disappear) and the fact that you get to see the full code, rather than just the patch. Cons include inferior text-editing capabilities, and inferior code browsing capabilities compared to applying the patch and browsing around in Emacs (but you can always checkout the branch, which I find nicer than applying patches by hand anyway). Clément.