From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: Regexp error scan (March 26) Date: Wed, 27 Mar 2019 10:14:29 +0100 Message-ID: <7E84CED0-9E85-45FB-8BBF-B87ED51F4818@acm.org> References: <0E648A80-8673-44DB-B481-981474AC3D7C@acm.org> <77419a89-ce9f-919b-c221-c7a3b938587a@cs.ucla.edu> <87h8bpvv74.fsf@tcd.ie> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="113829"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Paul Eggert , emacs-devel To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 27 10:15:24 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h94eZ-000TUr-DB for ged-emacs-devel@m.gmane.org; Wed, 27 Mar 2019 10:15:23 +0100 Original-Received: from localhost ([127.0.0.1]:44206 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h94eY-0003dV-Bh for ged-emacs-devel@m.gmane.org; Wed, 27 Mar 2019 05:15:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h94dy-0003dN-1o for emacs-devel@gnu.org; Wed, 27 Mar 2019 05:14:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h94dw-0005h7-5p for emacs-devel@gnu.org; Wed, 27 Mar 2019 05:14:46 -0400 Original-Received: from mail233c50.megamailservers.eu ([91.136.10.243]:53346 helo=mail37c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h94dv-0005fv-DD for emacs-devel@gnu.org; Wed, 27 Mar 2019 05:14:44 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1553678072; bh=1JGZ25GvtX1opGbtF2V5iCLryCc3q5lm5FgkTufy0lE=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=DeQU6mG4qZvLuMg4CsuhWWuTDxjqOg1glKh0O3k91u7mgbjpPXC+/OMGvurelTXfG NxKOpkFMrvYc7taZGuU9Jn11z5wqemm4VLvZ/PIFLW4wF5ImrgVyHZLkxwhOlf/B7R G2pabJH4GJghT8uHBfXoMzIEw6Z+zPnU8F7PYxU0= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail37c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x2R9ETQl015907; Wed, 27 Mar 2019 09:14:31 +0000 In-Reply-To: <87h8bpvv74.fsf@tcd.ie> X-Mailer: Apple Mail (2.3445.104.8) X-CTCH-RefID: str=0001.0A0B020D.5C9B3EF8.000F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=J+uEEjvS c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=MCQkrygxxuh-0ei73ggA:9 a=CjuIK1q_8ugA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 91.136.10.243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234764 Archived-At: 27 mars 2019 kl. 04.43 skrev Basil L. Contovounesios : > > Paul Eggert writes: > >> (replace-regexp-in-string >> - (format "[%s]" >> - (mapconcat (lambda (char) >> - (regexp-quote (char-to-string char))) >> - erc-lurker-ignore-chars "")) >> + (regexp-opt (cl-delete-duplicates >> + (mapcar #'char-to-string erc-lurker-ignore-chars))) >> "" nick) >> nick)) > > regexp-opt already deletes duplicates, so you can just: > > (regexp-opt (mapcar #'char-to-string erc-lurker-ignore-chars)) > > Besides, cl-delete-duplicates defaults to eql for equality, so it's a > no-op here anyway. Or perhaps: (regexp-opt-charset (append erc-lurker-ignore-chars nil))