From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Devlin Newsgroups: gmane.emacs.devel Subject: Re: igc, macOS avoiding signals Date: Sat, 28 Dec 2024 22:24:49 +0900 Message-ID: <799DDBC5-2C14-4476-B1E0-7BA2FE9E7901@toadstyle.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.113.1.2\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39896"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: gerd.moellmann@gmail.com, pipcet@protonmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 28 15:09:30 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tRXVR-000AHB-T9 for ged-emacs-devel@m.gmane-mx.org; Sat, 28 Dec 2024 15:09:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRXV0-0004Jt-Be; Sat, 28 Dec 2024 09:09:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRWoY-0004BG-Im for emacs-devel@gnu.org; Sat, 28 Dec 2024 08:25:13 -0500 Original-Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tRWoV-00062u-DN for emacs-devel@gnu.org; Sat, 28 Dec 2024 08:25:09 -0500 Original-Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-21675fd60feso131488315ad.2 for ; Sat, 28 Dec 2024 05:25:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toadstyle-org.20230601.gappssmtp.com; s=20230601; t=1735392303; x=1735997103; darn=gnu.org; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=ntO1gGM3olXsCrtywyepFZPulBCq1cKT/UNsmZuaqck=; b=FbQ2hwNcSFA7Ro6MktVZILhdYBLmgo/ahmeeA34zTJZwd6mVjzztvUgn4IlrhtRCNA 4w60d7mtu8smWvc33KLKK1n6mH4cHhjUjVQfIBauLJeQZZNM3XAWSZ+PP6eq9A/hutHD muZw3Hv0LjV71CSvlUpNMInZSpssP5K8tKYNFtqPZnf+rx6pYIgevB+1fdFMDUIjUyCe 5hiFcLNtgj+0zGel6eUSa+5tG+FsMK3QUzvdyeiKFLefSGW6/y4GL+6Y6j2kJyykJh19 ILORkvRxQV6Mest/KyVlieox5TQrVdPzE1HtcxgSt8QfB1xO9s8ZvfWa+VNTdSMkxvdQ H6qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735392303; x=1735997103; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ntO1gGM3olXsCrtywyepFZPulBCq1cKT/UNsmZuaqck=; b=cxkYBW71v51XljwTH+ks6nkDhferilWgpQAoIMJY6o74Tf01zqG9c1KXPoOyFiBzvL vkcRN1m1BKxMYL0nbw8zAovsRiOFwGltZ3S9Gy1U9K3ff75FiShCOfzZhIHrmNoXLBzF UezXPWyoBJQi/sdXE7kuGxPtH029V3H7o5C3J1xLYIwUXDy5RNkwvMJd5h5IcvFsi9Lb Ubj340IfxSkyJf8GB8HfOcSL1BUoYuFJ/rS/fjTPeSgm11Z8ggYS+vQP1d8GRzVrvCem y3Y9f+sqPDXMTs1S7KwbA1XxhR/OlJN3yZ5uTgTF4WjIJ0nIYhbzKXOgB0v6jpn2BbLV hknQ== X-Gm-Message-State: AOJu0YyDIOUUPakEQEPDDgK7t7SLwwpR4bvIB5YMLRnTkPVa3AWFjplt UFzSsk+keU512L4Bgc0dY3pNqUCkDYdH8xGd3P8u/WDSnV/iLsuGhMmYJptZYuE= X-Gm-Gg: ASbGncs7vDrlcRJ+/oQ7E0IKgTitGQpfm2X5TxYrc9XVwXYxoI6TOcboMDNPD3o5Jhr Bp1qxtoPyCDuBPApqlu0n8khrpL9d59I4O0f7I/5N61EqGnbHjufdLf8nNx7oCU7zrpWxob2AFe sYh/86PqHfgceiVwQGVeEGxTEwV7axkYpNG7CyxL57nX7gp5qHy4zFzisHRVfx1fweAJH56I1tB 1PnydjyshLeGOyns5Astpm+bXSLVcah6yjEL8kPHSMVGKKrpanfQ5ESeJDmYHnMluvSQqEtLj1m nd+ocqrEeUxhDaFUYRqxFShtnTfSqsu4m2SCnNzL X-Google-Smtp-Source: AGHT+IHUe+Jun3T8tndbwlA0J/mhxPWs2QGkEa/0Lv0uJkfMCffocDlMMo/H9nKL3fpFt/A1lYXLqA== X-Received: by 2002:a17:902:eccc:b0:20c:9936:f0ab with SMTP id d9443c01a7336-219e6f27fecmr422875075ad.47.1735392303445; Sat, 28 Dec 2024 05:25:03 -0800 (PST) Original-Received: from smtpclient.apple (111101095029.userreverse.wvs2.kddi.ne.jp. [111.101.95.29]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc9f7457sm146926615ad.201.2024.12.28.05.25.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Dec 2024 05:25:03 -0800 (PST) X-Mailer: Apple Mail (2.3826.400.113.1.2) Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=spd@toadstyle.org; helo=mail-pl1-x62c.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 28 Dec 2024 09:09:00 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327266 Archived-At: > Pip Cet writes: >=20 > > Gerd M=C3=B6llmann writes: > > > >> This is about commit > >> > >> ceec5ace134081b64dbf46c4fb5702ef5209c5fd > >> Avoid MPS being interrupted by signals > >> > >> I've been running with this for some days now, and must report that > >> Emacs feels a _bit_ different here in interactive use, maybe one = could > >> say not as smooth. (macOS, --without-ns, in my fork of Emacs, which = is > >> very recent master++). > > > > I think we should quantify that. Set a watchpoint on > > igc_global->signals_pending, check how often we even set that, and = how > > often we call igc_maybe_quit, particularly if we were previously = idle. > > Maybe it's sufficient to call it again from the idle handler. > > > >> After reverting the commit, it's feeling smoother again. > > > > Entirely possible. Let's measure it. >=20 > I'm sorry, but I pass. It's too time-consuming for me. Maybe someone > else using macOS can do that. I just wanted to make you aware of this. I can take a stab at this. I=E2=80=99ve been running the scratch/igc = branch on macOS using the NS build. To be clear, I should make sure to include the above commit in my build? = Or should I not include it? When I take my measurements, are there any kinds of tasks I should try = to perform? What durations of time should I try to measure? Cheers.=