Re: master 3b1fd42732f: * lisp/loadup.el: Check advice after `rmc.el`; turn error into warning

[Jens Schmidt <jschmidt4gnu@vodafonemail.de>]

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

On 2023-12-14  08:23, Eli Zaretskii wrote:

> So I don't think we should remove it from loadup.el at this time.

Agreed, and thanks for the background.

I understood from your previous email [1] that the current location of
where "rmc" is loaded in loadup.el is not optimal.

How about moving it to the block that also loads "minibuffer"?  Attached
patch does that and bootstraps and checks without error and warnings.

[1] https://lists.gnu.org/archive/html/emacs-devel/2023-12/msg00320.html


[-- Attachment #2: 0001-Move-preload-of-rmc-to-a-more-appropriate-place.patch --]
[-- Type: text/x-patch, Size: 1225 bytes --]

From 2e8a6c78c140390b2538b89906f11986815e7f53 Mon Sep 17 00:00:00 2001
From: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
Date: Thu, 14 Dec 2023 20:47:22 +0100
Subject: [PATCH] ; Move preload of rmc to a more appropriate place

See discussion on
https://lists.gnu.org/archive/html/emacs-devel/2023-12/msg00309.html.

* lisp/loadup.el ("emacs-lisp/rmc"): Move preload to a more
appropriate place.
---
 lisp/loadup.el | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lisp/loadup.el b/lisp/loadup.el
index 1f959464b23..1692b6ee7f3 100644
--- a/lisp/loadup.el
+++ b/lisp/loadup.el
@@ -256,6 +256,7 @@
 (load "emacs-lisp/syntax")
 (load "font-lock")
 (load "jit-lock")
+(load "emacs-lisp/rmc") ; Used by `kill-buffer', for instance.
 
 (load "mouse")
 ;; This loading happens on Android despite scroll bars being
@@ -406,9 +407,6 @@
       (message "Warning: Change in load-path due to site-load will be \
 lost after dumping")))
 
-;; Used by `kill-buffer', for instance.
-(load "emacs-lisp/rmc")
-
 ;; Actively check for advised functions during preload since:
 ;; - advices in Emacs's core are generally considered bad style;
 ;; - `Snarf-documentation' looses docstrings of primitives advised
-- 
2.30.2