unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: tumashu <tumashu@163.com>
To: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: [patch] two patchs about tab-bar.el
Date: Fri, 10 Sep 2021 12:39:25 +0800 (CST)	[thread overview]
Message-ID: <79741d39.2e84.17bce00d409.Coremail.tumashu@163.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #1.2: Type: text/html, Size: 111 bytes --]

[-- Attachment #2: 0001-tab-bar-fix-issue-when-current-tab-is-not-at-the-beg.patch --]
[-- Type: application/octet-stream, Size: 1130 bytes --]

From 63ba437acb54fc123b1885de5473345e8b8685f6 Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu@163.com>
Date: Fri, 10 Sep 2021 12:23:41 +0800
Subject: [PATCH 1/2] tab-bar: fix issue when 'current-tab is not at the
 beginning of tabs.

* lisp/tab-bar.el (tab-bar-get-buffer-tab): Fix issue when
'current-tab is not at the beginning of tabs.
---
 lisp/tab-bar.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el
index faa155c53f..54fbc04f3f 100644
--- a/lisp/tab-bar.el
+++ b/lisp/tab-bar.el
@@ -1940,7 +1940,9 @@ tab-bar-get-buffer-tab
                        (member (buffer-name buffer) buffers))))
               (append tab `((index . ,(tab-bar--tab-index tab nil frame))
                             (frame . ,frame)))))
-          (funcall tab-bar-tabs-function frame)))
+          (let ((tabs (funcall tab-bar-tabs-function frame)))
+            ;; Make sure current-tab is alway at the beginning of tabs.
+            (push (assq 'current-tab tabs) tabs))))
        (tab-bar--reusable-frames all-frames)))))
 
 (defun display-buffer-in-tab (buffer alist)
-- 
2.30.2


[-- Attachment #3: 0002-lisp-tab-bar.el-display-buffer-in-tab-Improve-docstr.patch --]
[-- Type: application/octet-stream, Size: 993 bytes --]

From 779dc12d680cd62a5f6da378f9e8bdcebd5602df Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu@163.com>
Date: Fri, 10 Sep 2021 12:35:37 +0800
Subject: [PATCH 2/2] * lisp/tab-bar.el (display-buffer-in-tab): Improve
 docstring.

---
 lisp/tab-bar.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el
index 54fbc04f3f..451af70f01 100644
--- a/lisp/tab-bar.el
+++ b/lisp/tab-bar.el
@@ -1962,11 +1962,12 @@ display-buffer-in-tab
 
 If ALIST contains a `reusable-frames' entry, its value determines
 which frames to search for a reusable tab:
-  nil -- the selected frame (actually the last non-minibuffer frame)
+  nil -- do not reuse any frames.
   A frame   -- just that frame
   `visible' -- all visible frames
   0   -- all frames on the current terminal
   t   -- all frames.
+  others -- selected frame.
 
 This is an action function for buffer display, see Info
 node `(elisp) Buffer Display Action Functions'.  It should be
-- 
2.30.2


             reply	other threads:[~2021-09-10  4:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10  4:39 tumashu [this message]
2021-09-10  6:33 ` [patch] two patchs about tab-bar.el Juri Linkov
2021-09-10 13:18   ` tumashu
2021-09-10 13:24   ` tumashu
2021-09-10 13:36   ` tumashu
2021-09-10 16:17     ` Juri Linkov
2021-09-10 18:33   ` tumashu
2021-09-12  7:03     ` Juri Linkov
2021-09-12  9:34       ` tumashu
2021-09-12 16:10         ` Juri Linkov
2021-09-10 23:48 ` Feng Shu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79741d39.2e84.17bce00d409.Coremail.tumashu@163.com \
    --to=tumashu@163.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).