From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: vertical fido-mode Date: Wed, 10 Jun 2020 21:54:01 +0000 (UTC) Message-ID: <795146083.1708851.1591826041689@mail.yahoo.com> References: <1704199899.1577092.1591806438580.ref@mail.yahoo.com> <1704199899.1577092.1591806438580@mail.yahoo.com> <13ec44ed-4b54-8d43-590f-709bd813fd01@yandex.ru> Reply-To: Ergus Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_1708850_1258424475.1591826041688" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="115410"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel@gnu.org" To: "dgutov@yandex.ru" , "monnier@iro.umontreal.ca" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 10 23:54:52 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jj8gN-000TvN-TD for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Jun 2020 23:54:52 +0200 Original-Received: from localhost ([::1]:46888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj8gM-0007lH-T2 for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Jun 2020 17:54:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj8fg-0007JX-Ol for emacs-devel@gnu.org; Wed, 10 Jun 2020 17:54:08 -0400 Original-Received: from sonic311-14.consmr.mail.bf2.yahoo.com ([74.6.131.124]:38847) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jj8fe-00055i-7E for emacs-devel@gnu.org; Wed, 10 Jun 2020 17:54:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1591826043; bh=fTxmDUN0qFku/WDuyaC3j9wxq4lXbAQUdKUSKgmetXQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:From:Subject; b=H61f+dSd6zW2qFznZejr1eTChZKyvOVFHdmrWww6l+LsBVTZHwCzHdV+8fDl7xoyns2dUv+xrnzKXTtcwawQ9VQNvmYsuROdTxCYfNKJBg2mjmpWsPjtqOMmUb9FFqIskTXBFldKAOiNAFqvsGzhmOnNYlnk6o+9pEPVF/rX3SXZzMwA40NnzPPl9vEpYbihBp72I6Kyo+g+8KyBTgm/mTCESz/gXpXhcHci00JICCE7ZDCe4GQcQV9fbBmDoTNiz4tc1TLEuCna126Mb1CaO1iIkiYON4nykEXRO7JSC4Gk9BCqBUmS4qsjeha6mItJItlJsCM+dEKPAXko7HkFIg== X-YMail-OSG: eo_T3HMVM1kGST.7_DfO8b66YSAKoiGoBvWZlNs3tloZRCCyjm3KTLKXUhKQcnr ThazR8.eda9rWjR9ID_Dt__z4_KajACCC4eS29Jd38Jl4s.YzX0GhOiQneAILEDOArlgf0XAZIea oZcygY1d63S6anbo_.z9tUaMZ8yTr4HvwLrgh.ZauNJL6st.Y1AaKhA23ycXJW4r1axB6DW1yZB6 lLIzxNBIHpKy.IsbARtlAzyfYUykLklU.55jPoI2PxgNFXM3QTZpcvxMa3RqWXlFhXggX5_WvEF8 LP1cUQORkLlc_wybseTxBsp4xMMc0WMETCAKX.rk9udPYNQ9uJ6bYlvtx5_kjVR672Zy.REpZD5L nHcG28nWcmY7pm719J3FPc_sYQ3DbfnylswH3djzio1qTOJJbk7jXnFgY4JPAJlzFY_NgmlG6zed 7_QX2XfUFrIKiaYHA6jF5tRv9RvolqtiTUupeUra690ZRq.dApN1kRG1keXLJCDHIHjCo8Ti6OR5 wKows9RSfkb.MjOwk0aQF_S4aTAb.eLgV31issPbn8K85Pq7eok7ysggrZ7tKEjbkEEB2blGrE.M Rz4YUWAPFHE.fh2OwQRIe1um2dKBQ7oFttx0bdfs8Bs.PRc22bHP1hUlp9aD9DPvW8mRvmNM_L.J dx7YVPceeSvvNeHMyv_M3BBfBvZU19ZSthdpBgMlheYuA_y3Q9aVUtpSN357pmZFMyzxEDWC9q84 I3WYhS9rjCdz0CoCaCoxJV6HaH81aFSpD8eqdYzB7OosPpR2lds5kG29rT92QKfhDM6QKpqszOsS CLbzcOgq1Gdikm0O6m4fkHY1o.QJjtk5qVGEkYjcd_ Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.bf2.yahoo.com with HTTP; Wed, 10 Jun 2020 21:54:03 +0000 In-Reply-To: <13ec44ed-4b54-8d43-590f-709bd813fd01@yandex.ru> X-Mailer: WebService/1.1.16072 aolwebmail Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.138 Safari/537.36 Received-SPF: pass client-ip=74.6.131.124; envelope-from=spacibba@aol.com; helo=sonic311-14.consmr.mail.bf2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/10 17:54:03 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252095 Archived-At: ------=_Part_1708850_1258424475.1591826041688 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Yes, that's a good.idea.=C2=A0 But as I see the code in=C2=A0icomplete-vertical-mode; it relies in a hook = (icomplete-vertical-minibuffer-setup) and an advice (icomplete-vertical-for= mat-completions) which in principle we don't need with a very simple modifi= cation of icomplete-completions and=C2=A0icomplete-minibuffer-setup. If=C2= =A0icomplete-completions produces the formated output it will be more effic= ient=C2=A0and clean than adding an advice or do a reformat. There are also some customizable options that for a simple working vertical= mode we shouldn't need (like=C2=A0icomplete-vertical-separator-alist or a = face icomplete-vertical-separator) unless we want to add them now. So in my opinion maybe we can provide the vertical mode in a simpler way ju= st improving=C2=A0icomplete-completions and some other small changes here a= nd there. WDYT? -----Original Message----- From: Dmitry Gutov To: Stefan Monnier ; Ergus Cc: emacs-devel@gnu.org Sent: Wed, Jun 10, 2020 9:01 pm Subject: Re: vertical fido-mode On 10.06.2020 19:53, Stefan Monnier wrote: > I think the icomplete-vertical functionality could/should be supported > directly by complete.el. Someone could contact the author of=20 https://github.com/oantolin/icomplete-vertical for copyright assignment=20 (and either incorporate the mode, or just some parts of it), in order=20 not to have to solve the same problems all over again. ------=_Part_1708850_1258424475.1591826041688 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit
Yes, that's a good.idea. 

But as I see the code in icomplete-vertical-mode; it relies in a hook (icomplete-vertical-minibuffer-setup) and an advice (icomplete-vertical-format-completions) which in principle we don't need with a very simple modification of icomplete-completions and icomplete-minibuffer-setup. If icomplete-completions produces the formated output it will be more efficient and clean than adding an advice or do a reformat.

There are also some customizable options that for a simple working vertical mode we shouldn't need (like icomplete-vertical-separator-alist or a face icomplete-vertical-separator) unless we want to add them now.

So in my opinion maybe we can provide the vertical mode in a simpler way just improving icomplete-completions and some other small changes here and there. WDYT?

-----Original Message-----
From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>; Ergus <spacibba@aol.com>
Cc: emacs-devel@gnu.org <emacs-devel@gnu.org>
Sent: Wed, Jun 10, 2020 9:01 pm
Subject: Re: vertical fido-mode

On 10.06.2020 19:53, Stefan Monnier wrote:

> I think the icomplete-vertical functionality could/should be supported
> directly by complete.el.


Someone could contact the author of
https://github.com/oantolin/icomplete-vertical for copyright assignment
(and either incorporate the mode, or just some parts of it), in order
not to have to solve the same problems all over again.


------=_Part_1708850_1258424475.1591826041688--