From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: Pip Cet <pipcet@protonmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 46f3452b30f: Simplify and speed up make-hash-table argument parsing
Date: Wed, 21 Aug 2024 16:03:29 +0200 [thread overview]
Message-ID: <79494B8D-8ED6-452A-8120-A807EAB2EDC4@gmail.com> (raw)
In-Reply-To: <87ed6i9eqt.fsf@protonmail.com>
21 aug. 2024 kl. 15.39 skrev Pip Cet <pipcet@protonmail.com>:
> This (removed) code used to accept calls such as
>
> (make-hash-table :rehash-size :test 'eq)
>
> which doesn't make sense, so we definitely should change something here.
Indeed, this is a change long overdue. It is also unfinished business from the recent hash-table reform; somehow it got lost in the shuffle.
> Is this really faster than not removing the position from the symbol in
> the first place?
Yes, because of the number of subsequent branches affected.
> The new code accepts duplicate arguments, such as
>
> (make-hash-table :test 'eq :test 'eq)
>
> Is that intentional, harmless, or undesirable?
Quite harmless and definitely not worth spending any cycles detecting, especially not at runtime.
> Anyway, it'll be even simpler once we remove purespace
Looking forward to it!
prev parent reply other threads:[~2024-08-21 14:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <172424463538.7415.12172458876271190421@vcs2.savannah.gnu.org>
[not found] ` <20240821125036.5728AC1F9FB@vcs2.savannah.gnu.org>
2024-08-21 13:39 ` master 46f3452b30f: Simplify and speed up make-hash-table argument parsing Pip Cet
2024-08-21 14:03 ` Mattias Engdegård [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79494B8D-8ED6-452A-8120-A807EAB2EDC4@gmail.com \
--to=mattias.engdegard@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=pipcet@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).