Re: [Emacs-diffs] trunk r113431: Stop cursor blink after blink-cursor-blinks (10), stop timers when not blinking.

Re: [Emacs-diffs] trunk r113431: Stop cursor blink after blink-cursor-blinks (10), stop timers when not blinking.

[Stefan Monnier]

>   * src/keyboard.c (Qfocus_in, Qfocus_out): New static objects.
>   (make_lispy_focus_in, make_lispy_focus_out): Declare and define.

Please document this in etc/NEWS.  Many people have asked for such
"hooks" to highlight the frame/buffer/window that has focus.

> +** The blink cursor stops blinking after 10 blinks (default) on X and NS.

Why not everywhere?


        Stefan

Re: [Emacs-diffs] trunk r113431: Stop cursor blink after blink-cursor-blinks (10), stop timers when not blinking.

[Jan Djärv]

Hello.

16 jul 2013 kl. 23:22 skrev Stefan Monnier <monnier@IRO.UMontreal.CA>:

>>  * src/keyboard.c (Qfocus_in, Qfocus_out): New static objects.
>>  (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
> 
> Please document this in etc/NEWS.  Many people have asked for such
> "hooks" to highlight the frame/buffer/window that has focus.
> 

The objects, events or functions?  I thought that events in special_map was kind of "internal", but I see switch-frame is documented.  I can document focus-in/out in a similar way.

>> +** The blink cursor stops blinking after 10 blinks (default) on X and NS.
> 
> Why not everywhere?
> 

A non-gui Emacs has no control of the cursor, it is a property of the underlying terminal.  Also, I don't have development environments on W32 or msdos, nor the time or diesire to set one up.

	Jan D.

Re: [Emacs-diffs] trunk r113431: Stop cursor blink after blink-cursor-blinks (10), stop timers when not blinking.

[Eli Zaretskii]

> From: Jan Djärv <jan.h.d@swipnet.se>
> Date: Wed, 17 Jul 2013 09:31:11 +0200
> Cc: emacs-devel@gnu.org
> 
> Also, I don't have development environments on W32 or msdos, nor the time or diesire to set one up.

The MSDOS part is a red herring: that one's a text-mode environment,
so the cursor blinks there in hardware and out of Emacs's control.

Re: [Emacs-diffs] trunk r113431: Stop cursor blink after blink-cursor-blinks (10), stop timers when not blinking.

[Stefan Monnier]

>>> * src/keyboard.c (Qfocus_in, Qfocus_out): New static objects.
>>> (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
>> Please document this in etc/NEWS.  Many people have asked for such
>> "hooks" to highlight the frame/buffer/window that has focus.
> The objects, events or functions?  I thought that events in special_map was
> kind of "internal", but I see switch-frame is documented.  I can document
> focus-in/out in a similar way.

Hmm... why is it in the special map?

>>> +** The blink cursor stops blinking after 10 blinks (default) on X and NS.
>> Why not everywhere?
> A non-gui Emacs has no control of the cursor, it is a property of the
> underlying terminal.

Why does it matter?  Such global compatibility details should presumably
be handled elsewhere by simply not enabling the blink-cursor timers
under ttys if it doesn't work (tho I do know it can be made to work in
some cases).


        Stefan

Re: [Emacs-diffs] trunk r113431: Stop cursor blink after blink-cursor-blinks (10), stop timers when not blinking.

[Jan Djärv]

Hello.

18 jul 2013 kl. 09:48 skrev Stefan Monnier <monnier@IRO.UMontreal.CA>:

>>>> * src/keyboard.c (Qfocus_in, Qfocus_out): New static objects.
>>>> (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
>>> Please document this in etc/NEWS.  Many people have asked for such
>>> "hooks" to highlight the frame/buffer/window that has focus.
>> The objects, events or functions?  I thought that events in special_map was
>> kind of "internal", but I see switch-frame is documented.  I can document
>> focus-in/out in a similar way.
> 
> Hmm... why is it in the special map?

Because switch-frame is there, and this is similar.

> 
>>>> +** The blink cursor stops blinking after 10 blinks (default) on X and NS.
>>> Why not everywhere?
>> A non-gui Emacs has no control of the cursor, it is a property of the
>> underlying terminal.
> 
> Why does it matter?  Such global compatibility details should presumably
> be handled elsewhere by simply not enabling the blink-cursor timers
> under ttys if it doesn't work (tho I do know it can be made to work in
> some cases).

blink-cursor-mode is not enabled by default on ttys.  It can be enabled manually, but it has no effect other than running the timers.  Also, there is really no concept of focus-out or focus-in in a tty session, we can't know when we have or loose focus.

	Jan D.

Re: [Emacs-diffs] trunk r113431: Stop cursor blink after blink-cursor-blinks (10), stop timers when not blinking.

[Stefan Monnier]

>> Why does it matter?  Such global compatibility details should presumably
>> be handled elsewhere by simply not enabling the blink-cursor timers
>> under ttys if it doesn't work (tho I do know it can be made to work in
>> some cases).
> blink-cursor-mode is not enabled by default on ttys.

Exactly my point: you don't need to "disable" your code under ttys,
since the code is not run anyway in that case.

> Also, there is really no concept of focus-out or focus-in in a tty
> session, we can't know when we have or loose focus.

I don't think we really need focus-in/focus-out for the feature to be
useful: you can just blink N times every time Emacs becomes idle and
then stop blinking.


        Stefan

Re: [Emacs-diffs] trunk r113431: Stop cursor blink after blink-cursor-blinks (10), stop timers when not blinking.

[Jan Djärv]

Hello.

18 jul 2013 kl. 10:46 skrev Stefan Monnier <monnier@IRO.UMontreal.CA>:

>>> Why does it matter?  Such global compatibility details should presumably
>>> be handled elsewhere by simply not enabling the blink-cursor timers
>>> under ttys if it doesn't work (tho I do know it can be made to work in
>>> some cases).
>> blink-cursor-mode is not enabled by default on ttys.
> 
> Exactly my point: you don't need to "disable" your code under ttys,
> since the code is not run anyway in that case.

I did not disable it for ttys in particular, but for w32.  If there is no focus-in implementation for w32 (as the case is right now), cursors won't start blinking when a frame gets focus again.

> 
>> Also, there is really no concept of focus-out or focus-in in a tty
>> session, we can't know when we have or loose focus.
> 
> I don't think we really need focus-in/focus-out for the feature to be
> useful: you can just blink N times every time Emacs becomes idle and
> then stop blinking.

But then the above applies, it won't stop blinking if the (for example) xterm looses focus and it wont start blining when the xterm regains focus.  The latter is more serious IMHO.

	Jan D.

Re: [Emacs-diffs] trunk r113431: Stop cursor blink after blink-cursor-blinks (10), stop timers when not blinking.

[Stefan Monnier]

> I did not disable it for ttys in particular, but for w32.  If there is no
> focus-in implementation for w32 (as the case is right now), cursors won't
> start blinking when a frame gets focus again.

That's right.  It will only blink again in response to an
actual command.  That's not best, but "until the feature is implemented
in w32" it doesn't sound terrible at all.

> But then the above applies, it won't stop blinking if the (for example)
> xterm looses focus and it wont start blining when the xterm regains focus.
> The latter is more serious IMHO.

I don't find it serious at all.  If you need to find the cursor, just
try to move it and it'll blink.


        Stefan

Re: [Emacs-diffs] trunk r113431: Stop cursor blink after blink-cursor-blinks (10), stop timers when not blinking.

[Stefan Monnier]

>>> The objects, events or functions?  I thought that events in special_map was
>>> kind of "internal", but I see switch-frame is documented.  I can document
>>> focus-in/out in a similar way.
>> Hmm... why is it in the special map?
> Because switch-frame is there, and this is similar.

Hmmm no, switch-frame is not in special-event-map.


        Stefan

Re: [Emacs-diffs] trunk r113431: Stop cursor blink after blink-cursor-blinks (10), stop timers when not blinking.

[Jan Djärv]

Hello.

20 jul 2013 kl. 09:55 skrev Stefan Monnier <monnier@iro.umontreal.ca>:

>>>> The objects, events or functions?  I thought that events in special_map was
>>>> kind of "internal", but I see switch-frame is documented.  I can document
>>>> focus-in/out in a similar way.
>>> Hmm... why is it in the special map?
>> Because switch-frame is there, and this is similar.
> 
> Hmmm no, switch-frame is not in special-event-map.
> 

Indeed, I must have misread the code.

	Jan D.