From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master ff4de1b: Fix quoting style in Lisp comments Date: Thu, 16 Sep 2021 16:37:24 +0300 Message-ID: <77d84977-9abc-67a4-5745-cb1d0eab5cc4@yandex.ru> References: <20210912165141.9491.52637@vcs0.savannah.gnu.org> <20210912165143.5BC1E20A5E@vcs0.savannah.gnu.org> <47d6e9a6-f334-eda9-2e08-0a946e51fc4a@yandex.ru> <83v934emk7.fsf@gnu.org> <87sfy8d7oo.fsf@gnus.org> <9194fc93-fb9c-000f-a35a-321ddd259893@gmx.at> <8735q5yi63.fsf@mail.linkov.net> <83czp9by3s.fsf@gnu.org> <05cbffe0-f89b-ff54-64f5-cd1d11bac4f5@yandex.ru> <831r5pbt7j.fsf@gnu.org> <83wnnhacy4.fsf@gnu.org> <40937e22-994f-466c-87be-4f70a522118a@yandex.ru> <83o88t9kgb.fsf@gnu.org> <9672aeae-a969-1526-003b-abb1b00b5b49@yandex.ru> <87sfy43dlt.fsf@gnus.org> <834kakadga.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18810"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Cc: rudalics@gmx.at, emacs-devel@gnu.org, stefan@marxist.se, monnier@iro.umontreal.ca, juri@linkov.net To: Eli Zaretskii , Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 16 15:39:26 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQrbp-0004k4-61 for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Sep 2021 15:39:25 +0200 Original-Received: from localhost ([::1]:51178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQrbo-0001Cy-2B for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Sep 2021 09:39:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34142) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQra3-0007YC-7H for emacs-devel@gnu.org; Thu, 16 Sep 2021 09:37:35 -0400 Original-Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:45786) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQrZx-0004rB-Kq; Thu, 16 Sep 2021 09:37:34 -0400 Original-Received: by mail-wr1-x42f.google.com with SMTP id d21so9505708wra.12; Thu, 16 Sep 2021 06:37:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6YDdWa9ErQ5T2A4Z3CuFMEgBmiBcrNwq+m1w4h2N6gE=; b=m4Um6J+/HIc0s//nHZNPMscPaK6NdhoYYPq+C0VNRq39+391cbN5yP5PHIrA3qKNht F5M9Hbap3W1sdOZ8a8BNF38BJFICKTaExK0OKxxKqYriyYUSXqQiiGEXGmjpOt0Bs2MC PeE52I0/SjBBhuarrmAD0z61D8HHfnQqNZOocOG7UhD4bmk0oIkFYDoSZK7KHhJbs1zs 8Fz5JCbQbgz1algdhuheV0s35GCWGnKhVVgmyY/AYHS0OCyOra6UDKSdMFwKh/A6qwZK 7oWV09lri7r80tnzIZABBiU0+2lk1os/402+gcTtZmdzNyymc5X8/NF5EZ6jzDUIzEhf HM9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6YDdWa9ErQ5T2A4Z3CuFMEgBmiBcrNwq+m1w4h2N6gE=; b=E1jzY61VG/auvWK7cDTNcAdtwDZMlk765daJFE9c7JvTrUvlVkOvujrTwaCf7KyZ8Z YLjMX6cheDeapnSzN2WS7On4FyfgsqztMAypYiRwESV1/YZ7dCBYDwUrxWLqpG8TDfDN I1LT1xP7KZuPoOeg+V75KA5+yDgS3g9SCuMQuqldN/3I3v/XzDQXoXQfTy7kSixKiWeY OSrxOAvHScRzIB6gcpOYATlAzVOGUsO3mbDvGBa9kT82QB/t+INmP3j6ynv+4d0mLdfV zv8k+mb9fGIvxDMV1Wg7OGB3+P7OzeKp3Os/MsOXxGuRmbeFeknnxrjlXeCaN4XKO+yQ A1rA== X-Gm-Message-State: AOAM533pJLyqzWIpKWYF7SaBsSSsZASxY4dxegtU/OjDwDgbUsja7jNI baBcrr15gfuo7Lypn8/hqjhhTpFta4s= X-Google-Smtp-Source: ABdhPJxHmSUj69etqG6B85IcRj2uOsO5bE4N1ZXs62dRU845pRkAXEcJhAZlFj+hKLpFrbV486nx4Q== X-Received: by 2002:adf:f545:: with SMTP id j5mr6191124wrp.9.1631799447787; Thu, 16 Sep 2021 06:37:27 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id s14sm3041242wmc.25.2021.09.16.06.37.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Sep 2021 06:37:27 -0700 (PDT) In-Reply-To: <834kakadga.fsf@gnu.org> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=raaahh@gmail.com; helo=mail-wr1-x42f.google.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-1.488, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274811 Archived-At: On 16.09.2021 15:53, Eli Zaretskii wrote: >> I agree with using '...' in plain text files, like NEWS and PROBLEMS. > > If this discussion indicates something it's that "plain text" is open > to interpretation, so if we will have a mandatory convention, we'd > need to come up with an explicit list. E.g., NEWS and PROBLEMS are by > default in Outline mode, not in Text mode, so someone could claim they > aren't "plain text". They are not program code. But they can have excerpts. >> .el/.c files are not plain text files, they are source code files, and I >> do not agree that we have to (or should) change the convention from >> `...' there. At least not until we have fixed our tool chain to >> respect '...' in .el/.c files -- and if we decide to move to '...', we >> should do so everywhere in those files: Both doc strings and comments. > > Well, we already have hundreds of quotes 'like this' in both Lisp and > C files, so if highlighting that is a problem, let's work on that, > because reverting all those hundreds of quotes sounds like a lot of > code churn. (Btw, C and Lisp are not the only programming languages > we use in Emacs sources, is the above valid for all the source files?) Are you arguing toward having multiple standards or no standard at all? I just did a search across .el files: rg --type lisp ';.*?[^=]\'[a-z][a-z_-]{6,}\'' results in 199 lines, a lot of which are "plain" quotations by themselves, e.g. test/lisp/so-long-tests/so-long-tests.el: 364: ;; is 'preserved' by default (using both options). 498: ;; will validate the 'reverted' state against this. (Note or lisp/vc/pcvs.el 85:;; add support for parsing 'modules' file ("cvs co -c") 97:;; - write 'cvs-mode-admin' to do arbitrary 'cvs admin' commands which don't require changing. Others refer to symbols but not global symbols (and thus don't benefit from code completion/navigation support so much), so not using proper markup could be excused. Either way, that is less than 200 examples, easy enough to undo. For comparison, rg --type lisp ';.*?[^=]`[a-z][a-z_-]{6,}\'' Reports 10691 lines. >> I don't think the ` character is "ugly" -- that Markdown (for >> instance) uses it for similar purposes (but as `...`) shows that >> it's a character that people are comfortable with using in >> semi-structured non-plain-text files like source code files. > > We've had this argument, and I'd prefer not to have it again. > (Markdown is not really relevant because `...` does not display with > these characters.) Where doesn't it display with these characters? In the source files? Yes it does. But like Stefan K. said, we could choose font-lock rules to have them displayed however you want. That's not the issue.