Re: Please test the merge of the concurrency branch

["Clément Pit--Claudel" <clement.pit@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2423 bytes --]

It builds fine on my machine, and it doesn't seem to break Proof General (which makes heavy use of subprocesses), nor any of my packages' test suites :)

However, make check seems to fail:

make[2]: Entering directory '/build/emacs/master-clean/doc/misc'
make[2]: Nothing to be done for 'info'.
make[2]: Leaving directory '/build/emacs/master-clean/doc/misc'
  GEN      info/dir
make[1]: Leaving directory '/build/emacs/master-clean'
make -C test check
make[1]: Entering directory '/build/emacs/master-clean/test'
rm -f *.tmp
test ! -d ./automated
Makefile:159: recipe for target 'check-no-automated-subdir' failed
make[1]: *** [check-no-automated-subdir] Error 1
make[1]: Leaving directory '/build/emacs/master-clean/test'
Makefile:964: recipe for target 'check' failed
make: *** [check] Error 2

This is most likely a sign of my inability to run the test suite properly, of course.

Good job on the merge! Exciting stuff.

Cheers,
Clément.

On 2016-12-09 10:30, Robert Marshall wrote:
> Eli Zaretskii <eliz@gnu.org> writes:
> 
>> I've pushed to the Emacs Git repository a new branch named
>> 'test-concurrency'.  It's the result of merging the concurrency branch
>> with a week-old master, followed by fixing a few bugs I found (after
>> resolving the merge conflicts).
>>
>> This is tested on Trisquel GNU/Linux (x86_64 build) and on MS-Windows
>> (x86 build with wide ints).  "Tested" here means that it builds,
>> passes the test suite as well as the master version on the same
>> machine, passes the new tests that test the concurrency features, and
>> the basic functionalities that are affected by the concurrency-related
>> changes -- subprocesses and networking -- work as well as they do on
>> master.
>>
>> The new concurrency features are not thoroughly tested, so I expect
>> bugs to be reported when people start using them seriously.  I don't
>> think that should preclude us from landing this on master, though, as
>> long as the "usual", a.k.a. "single-threaded" Emacs works as well as
>> the master branch.
>>
> 
> It fails to build for me
> 
>  CC       category.o
> In file included from thread.h:22:0,
>                  from lisp.h:797,
>                  from category.c:33:
> regex.h:438:9: error: unknown type name ‘ssize_t’
> (and a few more complaints about ssize_t)
> 
> 	Debian GNU/Linux 8.6 (jessie)
> 
> Robert
> 
> 
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]