From: "Drew Adams" <drew.adams@oracle.com>
To: "'Chong Yidong'" <cyd@stupidchicken.com>
Cc: 'Stefan Monnier' <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: RE: dropped 4th arg from all-completions
Date: Tue, 27 Apr 2010 15:02:57 -0700 [thread overview]
Message-ID: <7784D87EC0E84A69890C3ADD2B7EAE44@us.oracle.com> (raw)
In-Reply-To: <87mxwo4llj.fsf@stupidchicken.com>
> > Emacs does not raise an error, but it does not respect the arg.
>
> (all-completions "" '(" asdfgh") nil nil)
> => (" asdf")
>
> (all-completions "" '(" asdfgh") nil t)
> => nil
Mille excuses for that part. I apparently checked only with a string that starts
with a space, which is the exceptional case where matching occurs anyway
("ignored unless STRING itself starts with a space"):
(all-completions " abc" '((" abc") ("a")) nil t)
=> (" abc")
That doesn't change the rest, but I'm glad this is still supported under the
covers.
The 4th arg should not be deprecated and it should be documented normally. And
changes like this should not be made with no proposal, no reasons given (still
the case), and no discussion.
next prev parent reply other threads:[~2010-04-27 22:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 16:01 dropped 4th arg from all-completions Drew Adams
2010-04-27 18:12 ` Stefan Monnier
2010-04-27 20:27 ` Drew Adams
2010-04-27 21:44 ` Chong Yidong
2010-04-27 22:02 ` Drew Adams [this message]
2010-04-28 4:09 ` Stefan Monnier
2010-04-28 4:29 ` Jay Belanger
2010-04-28 5:13 ` David Kastrup
2010-04-28 14:20 ` Stefan Monnier
2010-04-28 16:53 ` Jay Belanger
2010-04-28 6:53 ` Stephen J. Turnbull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7784D87EC0E84A69890C3ADD2B7EAE44@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).