From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Erik Selberg Newsgroups: gmane.emacs.devel Subject: Re: comint fix for shell colors Date: Fri, 18 Nov 2016 07:40:24 -0800 Message-ID: <77045C72-EB22-4EC8-B280-E74378B57A8E@selberg.org> References: <83twb5cd8t.fsf@gnu.org> <582f0f65.En4KsDnZnxPG7ZLy%wjenkner@inode.at> <83k2c0df63.fsf@gnu.org> <582f18f4.iBWOd+O4h9885qPS%wjenkner@inode.at> <83h974dcnw.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1479483686 16127 195.159.176.226 (18 Nov 2016 15:41:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 18 Nov 2016 15:41:26 +0000 (UTC) Cc: Wolfgang Jenkner , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 18 16:41:20 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7lHz-0002gT-Hk for ged-emacs-devel@m.gmane.org; Fri, 18 Nov 2016 16:41:19 +0100 Original-Received: from localhost ([::1]:37425 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7lI2-0001iG-Jp for ged-emacs-devel@m.gmane.org; Fri, 18 Nov 2016 10:41:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7lHF-0001h3-Iz for emacs-devel@gnu.org; Fri, 18 Nov 2016 10:40:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7lHE-0006SP-OM for emacs-devel@gnu.org; Fri, 18 Nov 2016 10:40:33 -0500 Original-Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]:32787) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c7lH9-0006Ns-RY; Fri, 18 Nov 2016 10:40:27 -0500 Original-Received: by mail-pf0-x241.google.com with SMTP id 144so13809906pfv.0; Fri, 18 Nov 2016 07:40:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Il/KwZbMOi8R1ZRlhRu7XDMU08DwyWlkV+KxBzOHg7E=; b=Q8waOGEWurLp7DFbHtzdMVoEYMH6xzvLubqr621xrE0MykZIJ2EOZj/uhRitoMSoAS 6/z+POndkkYT9ZyhkEf1MspUscBgRMQCjdh9cLhz4i2/GXzta8scyr4l2ItJMCd78Zt7 PI3Gw5xLbt9QBl2Wdgu8zjQaWGY/VFryj4uv/B2FrWTNBlEJP19EfcgubWjFHmora1yg 81it84c4Nve55Es+01ID9e9ChFMnkPHvWsPHcwUqvixggrX4gnGw52XWoTqfxn/IUVYk NUpvhLIFgZN5L01tLxIkVt/+x3CxP3L3+qRdPM8f4GkDLcgNh90QJj4rRdXTRt/SEKMa 2WUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:mime-version:subject:from:in-reply-to :date:cc:content-transfer-encoding:message-id:references:to; bh=Il/KwZbMOi8R1ZRlhRu7XDMU08DwyWlkV+KxBzOHg7E=; b=U+yaiiBIfNI3M8OusjoWNB8++KlJGywIIDZ16IfMSNl9DrFyK6wHT1PwKgc2DfHiae NPEcy7RUAZoZZhtfisHj3nNJ0tcLLre5F/VSVnVnSy5TcpGRGBGLDNvRKqTSyD0r6L+A Ib0XlxDCyp1nh51cAWpfPQFJSYgYyygHPVUbjkElc7gL8slbeJ50P+G6VaFJR1K/3iYO iWhM+u5EyqhJxoKq/2BhnGF1Yywjy0MtszyfEYy1i1ybJBhdhLPpn4xZszBr2L/favB3 RISSgjjCvVvqARbsLOV1XyoKMUk4XXHgpbIEzWeXp+gZmYKvbykqhyvp80rpjQCZRkSJ Ojnw== X-Gm-Message-State: AKaTC03NUOtFQJHzI7aByVp1V1ZwT0LRb6aV/2qwrjepIKxlmblU7REr/fYVaD0xxjh8tw== X-Received: by 10.98.159.136 with SMTP id v8mr458678pfk.82.1479483626093; Fri, 18 Nov 2016 07:40:26 -0800 (PST) Original-Received: from [192.168.0.226] (71-212-117-24.tukw.qwest.net. [71.212.117.24]) by smtp.gmail.com with ESMTPSA id u23sm18921393pfg.86.2016.11.18.07.40.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Nov 2016 07:40:25 -0800 (PST) X-Mailer: iPhone Mail (14B150) In-Reply-To: <83h974dcnw.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::241 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209481 Archived-At: Thanks for the feedback, I'll rebase. I do believe this is needed; when the shell prompt is multicolor (for examin= e using the agnoster theme as shown in the screenshot) applying a face remov= es the shell coloring. Cheers, -e Sent from my iPhone On Nov 18, 2016, at 7:34 AM, Eli Zaretskii wrote: >> Date: Fri, 18 Nov 2016 16:06:28 +0100 >> From: Wolfgang Jenkner >> Cc: erik@selberg.org, emacs-devel@gnu.org >>=20 >>> Indeed, I think this change should be described in NEWS. Could you >>> provide a patch for that, please? >>=20 >> Please note that there's nothing new here, it was just a bug fix. >> The very first message in the bug report mentioned above states >>=20 >> In Emacs 24.3, comint-highlight-prompt allows ANSI colors to show t= hrough >> if it does not specify any colors itself. In Emacs 24.4, it does n= ot, even >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> if comint-highlight-prompt is the "empty face". >=20 > Then how do you explain the OP's confusion on this matter? >=20