From: Erik Selberg <erik@selberg.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Wolfgang Jenkner <wjenkner@inode.at>, emacs-devel@gnu.org
Subject: Re: comint fix for shell colors
Date: Fri, 18 Nov 2016 07:40:24 -0800 [thread overview]
Message-ID: <77045C72-EB22-4EC8-B280-E74378B57A8E@selberg.org> (raw)
In-Reply-To: <83h974dcnw.fsf@gnu.org>
Thanks for the feedback, I'll rebase.
I do believe this is needed; when the shell prompt is multicolor (for examine using the agnoster theme as shown in the screenshot) applying a face removes the shell coloring.
Cheers,
-e
Sent from my iPhone
On Nov 18, 2016, at 7:34 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Fri, 18 Nov 2016 16:06:28 +0100
>> From: Wolfgang Jenkner <wjenkner@inode.at>
>> Cc: erik@selberg.org, emacs-devel@gnu.org
>>
>>> Indeed, I think this change should be described in NEWS. Could you
>>> provide a patch for that, please?
>>
>> Please note that there's nothing new here, it was just a bug fix.
>> The very first message in the bug report mentioned above states
>>
>> In Emacs 24.3, comint-highlight-prompt allows ANSI colors to show through
>> if it does not specify any colors itself. In Emacs 24.4, it does not, even
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> if comint-highlight-prompt is the "empty face".
>
> Then how do you explain the OP's confusion on this matter?
>
next prev parent reply other threads:[~2016-11-18 15:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 7:14 comint fix for shell colors Erik Selberg
2016-11-18 10:07 ` Eli Zaretskii
2016-11-18 14:25 ` Wolfgang Jenkner
2016-11-18 14:40 ` Eli Zaretskii
2016-11-18 15:06 ` Wolfgang Jenkner
2016-11-18 15:34 ` Eli Zaretskii
2016-11-18 15:40 ` Erik Selberg [this message]
2016-11-18 15:49 ` Wolfgang Jenkner
2016-11-18 15:53 ` Erik Selberg
2016-11-18 19:24 ` Erik Selberg
2016-11-18 19:50 ` Eli Zaretskii
2016-11-18 22:43 ` Erik Selberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77045C72-EB22-4EC8-B280-E74378B57A8E@selberg.org \
--to=erik@selberg.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=wjenkner@inode.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).