From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Tue, 1 Jun 2021 17:06:39 +0200 Message-ID: <76b5aee4-8eec-7998-23d1-d63d86e4b956@daniel-mendler.de> References: <87zgwlb4xc.fsf@gmail.com> <617d06ca-27bf-2ae8-26eb-1042123499d3@daniel-mendler.de> <87pmxhb1rs.fsf@gmail.com> <23510125-37b9-e87e-3590-5322f44772ce@daniel-mendler.de> <87y2c5nhsr.fsf@mail.linkov.net> <87h7irss50.fsf@mail.linkov.net> <43d1599e-2ba9-2efb-45c3-76c67d29a69d@daniel-mendler.de> <87tumrgqrb.fsf@gmail.com> <87tumq92pe.fsf@mail.linkov.net> <87lf82g10g.fsf@gmail.com> <87y2c24lww.fsf@mail.linkov.net> <871r9t2lsy.fsf@mail.linkov.net> <22880197-6d05-c821-2c58-328ed3cfc02e@daniel-mendler.de> <87eedruui3.fsf@gmail.com> <8dd915fe-fe67-2a45-67ff-8aaa3e9b9aca@daniel-mendler.de> <878s3zuq47.fsf@gmail.com> <09f2a253-84ba-5cfd-552e-0b89109864a5@daniel-mendler.de> <875yyxaoxp.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11636"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Juri Linkov , =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 01 17:29:28 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lo6Ke-0002vb-F0 for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Jun 2021 17:29:28 +0200 Original-Received: from localhost ([::1]:41866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lo6Kd-0005Lx-Gt for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Jun 2021 11:29:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo5yh-0004Gy-I0 for emacs-devel@gnu.org; Tue, 01 Jun 2021 11:06:47 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:55381 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo5ye-00067d-Bc for emacs-devel@gnu.org; Tue, 01 Jun 2021 11:06:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=v8/ErPIbB6OlRcWPQVlni36jnt6D7i+bGoToTGLQeD8=; b=loed+sjNv4aUOfzAPDMyi0hAkH xuoGxzs6h6Qg8yw1mRbXWvVHFm3kvTB9RxDN6pCaQq2JfWmwrA2czjnuj2AbWl8KorIG0NPPS+11I d5BCF6oqwffEIS73z4X/3aCCmlQe6ln4EqfKhv4TThOnrS/uMqErhtjE4IIfajK50NGM=; In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270206 Archived-At: On 6/1/21 4:58 PM, Gregory Heytings wrote: >> Regarding the annotations I disagree. The default *Completions* UI also >> annotates by default with not possibility for the user to turn this off, >> except by overwriting the `annotation-function` itself for example by >> advising `completion-metadata-get`. > > And this is (for me, and likely for others) one of the differences between > the *Completions* buffer and the minibuffer. I'm not against making it > possible to display annotations in the minibuffer for those who want to > see them there, but hardcoding them is IMO wrong. I am not against offering a customization option in the UI to enable/disable annotations. Note that there is also the `completions-detailed` variable, which guards some uses of the `affixation-function`. The `annotation-functions` seem to be unguarded. The design which I would prefer would be to check the `completions-detailed` variable once in the completion UI (Icomplete, default *Completions*) and depending on the value show the annotations or not. > And as I said users might want to display these annotations with their > own formatting, e.g. to display only some but not all of them in the > minibuffer. This is not a good idea in my opinion, at least for the `annotation-functions`. Annotations are only strings, there is not much formatting the user can do here. But more general use cases could be supported by a `decoration-function` (replacement for the current `affixation-function`) we discussed a few days ago. The `decoration-function` would return a list of semantic annotation/decoration fields given a candidate. Daniel