From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: removing flatten-list (alias for new flatten-tree function) Date: Mon, 17 Dec 2018 10:40:44 -0800 Organization: UCLA Computer Science Department Message-ID: <76ae4692-717a-4e68-e882-453ac8e0df62@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------EFD5DDC7A9CE0BFB2B3D2A82" X-Trace: blaine.gmane.org 1545071941 4144 195.159.176.226 (17 Dec 2018 18:39:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Dec 2018 18:39:01 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 Cc: Michael Albinus , Emacs development discussions To: Alex Branham , "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 17 19:38:57 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYxn5-0000u8-6q for ged-emacs-devel@m.gmane.org; Mon, 17 Dec 2018 19:38:55 +0100 Original-Received: from localhost ([::1]:48378 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYxpB-0003mc-Io for ged-emacs-devel@m.gmane.org; Mon, 17 Dec 2018 13:41:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYxp4-0003lr-TY for emacs-devel@gnu.org; Mon, 17 Dec 2018 13:40:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYxp1-0004QG-2v for emacs-devel@gnu.org; Mon, 17 Dec 2018 13:40:58 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:49974) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gYxox-0004Ls-Pq for emacs-devel@gnu.org; Mon, 17 Dec 2018 13:40:53 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4FE681609B2; Mon, 17 Dec 2018 10:40:49 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id F2-23PDZ2cy8; Mon, 17 Dec 2018 10:40:48 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 759881609B4; Mon, 17 Dec 2018 10:40:48 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Z8K-DlUS87nA; Mon, 17 Dec 2018 10:40:48 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 582661608EC; Mon, 17 Dec 2018 10:40:48 -0800 (PST) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231887 Archived-At: This is a multi-part message in MIME format. --------------EFD5DDC7A9CE0BFB2B3D2A82 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for writing the new flatten-tree function and cleaning up existing duplicate functions. I tweaked its performance a bit and cleaned up some more duplicates. While doing that I found that I was confused by the existence of the just-added alias 'flatten-list', and I propose removing it as per the attached patch. I think people who want to find and use the new 'flatten-tree' function will typically be better served if it has just one name that fits in with existing Emacs Lisp functions like 'copy-tree', as opposed to also having a name that is a misnomer. --------------EFD5DDC7A9CE0BFB2B3D2A82 Content-Type: text/x-patch; name="0001-lisp-subr.el-flatten-list-Remove.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-lisp-subr.el-flatten-list-Remove.patch" >From b1c894069483adf39b5f4d1f0cdd8f1aeecb87e9 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon, 17 Dec 2018 10:28:14 -0800 Subject: [PATCH] * lisp/subr.el (flatten-list): Remove. --- etc/NEWS | 6 ++---- lisp/subr.el | 4 ---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 327276eef9..9c6401d204 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1360,10 +1360,8 @@ are implemented in C using the Jansson library. 'ring-resize' can be used to grow or shrink a ring. +++ -** New function 'flatten-tree'. -'flatten-list' is provided as an alias. These functions take a tree -and 'flatten' it such that the result is a list of all the terminal -nodes. +** New function 'flatten-tree' returns a "flattened" copy of a tree, +such that the result is a list of all the terminal nodes. ** Mailcap diff --git a/lisp/subr.el b/lisp/subr.el index c5004a539b..0bb04d5e0a 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -5466,8 +5466,4 @@ flatten-tree (if tree (push tree elems)) (nreverse elems))) -;; Technically, `flatten-list' is a misnomer, but we provide it here -;; for discoverability: -(defalias 'flatten-list 'flatten-tree) - ;;; subr.el ends here -- 2.19.2 --------------EFD5DDC7A9CE0BFB2B3D2A82--