From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: p.stephani2@gmail.com, emacs-devel@gnu.org
Subject: Re: Enabling --enable-check-lisp-object-type by default on x86 and AMD64
Date: Fri, 5 May 2017 16:23:52 -0700 [thread overview]
Message-ID: <764aeab0-964a-3225-d236-d44853f888a0@cs.ucla.edu> (raw)
In-Reply-To: <83efw5hkby.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 950 bytes --]
On 05/03/2017 11:22 AM, Eli Zaretskii wrote:
> This is better, but how sure we are people's GDB is built with Python
> support?
We can ask developers to upgrade. GDB pretty-printing has worked with
embedded Python for several years (since GDB 7.3 in 2011, I believe). We
are not talking about general Emacs users here, only developers who are
building bleeding-edge Emacs from Git. It's reasonable to expect these
folks to have reasonably modern tools, especially since the only problem
here is that the backtrace will be a bit harder to read if they use an
old GDB.
> Why not make this part of .gdbinit itself?
Sure, we can do that.
> Also, the Python script should be a bit smarter, to support also the
> compilation without --enable-check-lisp-object-type. When I try this
> script in such a build, GDB crashes when displaying a backtrace.
Also doable.
I installed the attached, which I hope addresses the above issues well
enough.
[-- Attachment #2: 0001-Pretty-print-Lisp_Object-values-in-GDB.patch --]
[-- Type: text/x-patch, Size: 2878 bytes --]
From f46a91a7811c359fae9c1c2a7f9374f9c5303209 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Fri, 5 May 2017 15:59:24 -0700
Subject: [PATCH] Pretty-print Lisp_Object values in GDB
* src/.gdbinit: Add a pretty-printer for Lisp_Object values. Now,
GDB displays them as "XIL(0xXXX)" rather than displaying them
as "..." when CHECK_LISP_OBJECT_TYPE is in effect and as "DDDDD"
otherwise.
---
src/.gdbinit | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 57 insertions(+)
diff --git a/src/.gdbinit b/src/.gdbinit
index 6d7476d..0596188 100644
--- a/src/.gdbinit
+++ b/src/.gdbinit
@@ -1264,3 +1264,60 @@ commands
end
continue
end
+
+
+# Put the Python code at the end of .gdbinit so that if GDB does not
+# support Python, GDB will do all the above initializations before
+# reporting an error.
+
+python
+
+# Omit pretty-printing in older (pre-7.3) GDBs that lack it.
+if hasattr(gdb, 'printing'):
+
+ class Emacs_Pretty_Printers (gdb.printing.RegexpCollectionPrettyPrinter):
+ """A collection of pretty-printers. This is like GDB's
+ RegexpCollectionPrettyPrinter except when printing Lisp_Object."""
+ def __call__ (self, val):
+ """Look up the pretty-printer for the provided value."""
+ type = val.type
+ typename = type.tag or type.name
+ basic_type = gdb.types.get_basic_type (type)
+ basic_typename = basic_type.tag or basic_type.name
+ for printer in self.subprinters:
+ if (printer.enabled
+ and ((printer.regexp == '^Lisp_Object$'
+ and typename == 'Lisp_Object')
+ or (basic_typename
+ and printer.compiled_re.search (basic_typename)))):
+ return printer.gen_printer (val)
+ return None
+
+ class Lisp_Object_Printer:
+ "A printer for Lisp_Object values."
+ def __init__ (self, val):
+ self.val = val
+
+ def to_string (self):
+ "Yield a string that can be fed back into GDB."
+ val = self.val
+ basic_type = gdb.types.get_basic_type (val.type)
+ if (basic_type.code == gdb.TYPE_CODE_STRUCT
+ and gdb.types.has_field (basic_type, "i")):
+ val = val["i"]
+ # Yield "XIL(N)", where N is a C integer. This helps humans
+ # distinguish Lisp_Object values from ordinary integers even
+ # when Lisp_Object is an integer. Perhaps some day the
+ # pretty-printing could be fancier.
+ if not val:
+ return "XIL(0)" # Easier to read than "XIL(0x0)".
+ return "XIL(0x%x)" % val
+
+ def build_pretty_printer ():
+ pp = Emacs_Pretty_Printers ("Emacs")
+ pp.add_printer ('Lisp_Object', '^Lisp_Object$', Lisp_Object_Printer)
+ return pp
+
+ gdb.printing.register_pretty_printer (gdb.current_objfile (),
+ build_pretty_printer (), True)
+end
--
2.9.3
next prev parent reply other threads:[~2017-05-05 23:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m2shl134rd.fsf@gmail.com>
[not found] ` <83mvb8riq0.fsf@gnu.org>
[not found] ` <CAArVCkQoeBwHspkUUih_9EdwnBQ5HWaYHD87Rcyduc8DsooXRg@mail.gmail.com>
[not found] ` <83a878r2d0.fsf@gnu.org>
2017-05-01 11:32 ` Enabling --enable-check-lisp-object-type by default on x86 and AMD64 (was: Re: bug#26597: 25.1; Compilation error on master with --enable-check-lisp-object-type) Philipp Stephani
2017-05-02 22:14 ` Enabling --enable-check-lisp-object-type by default on x86 and AMD64 Paul Eggert
2017-05-03 2:38 ` Eli Zaretskii
2017-05-03 3:24 ` Paul Eggert
2017-05-03 14:48 ` Eli Zaretskii
2017-05-03 18:08 ` Paul Eggert
2017-05-03 18:22 ` Eli Zaretskii
2017-05-04 14:33 ` Eli Zaretskii
2017-05-05 23:23 ` Paul Eggert [this message]
2017-05-06 7:07 ` Eli Zaretskii
2017-05-06 23:23 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=764aeab0-964a-3225-d236-d44853f888a0@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).