From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 59a895ec499: ; * .gitignore: Add lisp/eshell/esh-groups.el. Date: Sun, 28 Jul 2024 11:00:48 -0700 Message-ID: <761d78b8-8f69-a316-1f62-ef9bcad8df09@gmail.com> References: <172200213962.12077.5959128939547244584@vcs2.savannah.gnu.org> <20240726135539.EFFE2C3535E@vcs2.savannah.gnu.org> <86257a62-bad8-414d-a73f-d9b820998768@gmail.com> <86r0bdza14.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21680"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 28 20:01:53 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sY8DR-0005YI-ET for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Jul 2024 20:01:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sY8Cg-0004uA-0z; Sun, 28 Jul 2024 14:01:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sY8CX-0004pK-JU for emacs-devel@gnu.org; Sun, 28 Jul 2024 14:01:02 -0400 Original-Received: from mail-oi1-x236.google.com ([2607:f8b0:4864:20::236]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sY8CQ-0008JB-As; Sun, 28 Jul 2024 14:00:52 -0400 Original-Received: by mail-oi1-x236.google.com with SMTP id 5614622812f47-3db16b2c1d2so1988958b6e.2; Sun, 28 Jul 2024 11:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722189647; x=1722794447; darn=gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=S7sn187+N+OQzphuIJQvs4SgeYTJ1kCTnxs0TUgNvnU=; b=VP85sd2iPp57K8LCeseq0Cuwx1o6s89xE2v7v6dhiiu+PLVWTxuOtFF5G3W4/oWJI5 wtheSds8/WyXohIS7IpgP5adrkR6d9VhKExOZb0KYk6mD+tmz7rNtyGsePoKYRpA3S5Y froE2Lu8q5959w9yRsCWwPzjQnpHjbaQQXWPsttByNdg7IEot74kxS2g6KfvYNHao8N/ cpyTD1IZTiXt8qZVZNgle8gqQP3AboJhJQ8CUvEOUZnHmSeOG4cNXgS8qDdrZKgGcXhM Oh20vWomQiScbrIUohLJv5MV8tEEG+lYJqec5g9EY32lvo5LR+ER7tAyISWuSeMAzg8W JOHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722189647; x=1722794447; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S7sn187+N+OQzphuIJQvs4SgeYTJ1kCTnxs0TUgNvnU=; b=s78dMPbI4MP/6I8Jnvth/8GJ7G04OgOGP8SCbItVpdiNpo147is0ReKDlW9avzB3lW zMNlkkb0ZH1FYit40NA4iCBkm3ke8nCsJslcqPRYG9x/45N9YdtD3xGkzIBibLMIHR5s J3vJ3ZINqoRsESbxz4c1RM6/8X4x1jhSD9KrZe/a6s569TR0rB6jNfdsHjuyXIimb6ow FqNtC3XJ8e6GE2VkFjETFQQ31JsdrBEl6ZHmqIQJtXReycHwaZmjGwyeIbOf9wPPJX2h kO1wlHezT4ljFmnoA86gMW7ZiewhNvg7fu6dp7fsP9LWHzM/7uG4vny5Yw1ACilsfIIP 8bAQ== X-Gm-Message-State: AOJu0YxJLcSaOvoRuxv9RbZxgmmCAh7sg+CpnjmKYdxDEHghlnMiEqZI OCFWMuPb8QQvUi/Vc1u6nj+aJdg8PzYI1FagI4ejtgNRq/m6DDI2uFyKPQ== X-Google-Smtp-Source: AGHT+IFVx4xv8PRCCxr/Q6EpCpbBmP1BS1CC58cJke0evCys99UrADD/YFg1GBprFzwvyrg8UBHzWQ== X-Received: by 2002:a05:6808:1a20:b0:3da:e2a2:75b1 with SMTP id 5614622812f47-3db239d39d6mr6499455b6e.13.1722189647245; Sun, 28 Jul 2024 11:00:47 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-7a9f884c245sm5938967a12.50.2024.07.28.11.00.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Jul 2024 11:00:46 -0700 (PDT) Content-Language: en-US In-Reply-To: <86r0bdza14.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::236; envelope-from=jporterbugs@gmail.com; helo=mail-oi1-x236.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322176 Archived-At: On 7/28/2024 10:44 AM, Eli Zaretskii wrote: >> Date: Sun, 28 Jul 2024 10:21:30 -0700 >> From: Jim Porter >> >> I don't see any issue with leaving "esh-groups.el" in the gitignore if >> it's more convenient for switching between older branches though. Would >> a comment here be useful to indicate that at some point in the future, >> people could remove that entry? > > Why remove it? I figured if that file existed on a newer revision it would be worth knowing about. Maybe someone in the future would want to make a file named "esh-groups.el" with different content and would be confused that it didn't get committed (I've been bitten by this before in other projects, though usually with wildcards or directories). That said, it's no real problem to keep it around either. At worst it's a single useless line in the gitignore.