From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: emacs master + org Wrong type argument: number-or-marker-p Date: Tue, 02 Aug 2022 08:43:45 +0000 Message-ID: <74ddc877f1a59b576a9f@heytings.org> References: <83bkt42ifq.fsf@gnu.org> <87a68ovw0b.fsf@posteo.net> <835yjc2c6f.fsf@gnu.org> <8335eg2ao9.fsf@gnu.org> <875yjbexde.fsf@posteo.net> <83zggn2a0c.fsf@gnu.org> <03AF0800-5252-429C-86BC-85DF9DF449F9@acm.org> <83tu6v27yh.fsf@gnu.org> <6F871C02-AC26-4B89-B64B-E9F4ACACDBE7@acm.org> <83sfmf26b6.fsf@gnu.org> <352C68A4-9CD0-471C-924E-D3858F2561BB@acm.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21809"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Philip Kaludercic , silent2600@gmail.com, emacs-devel@gnu.org To: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 02 11:03:42 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oInoU-0005ME-7Y for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Aug 2022 11:03:42 +0200 Original-Received: from localhost ([::1]:33174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oInoT-0006lm-3k for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Aug 2022 05:03:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oInVG-0008G1-2X for emacs-devel@gnu.org; Tue, 02 Aug 2022 04:43:50 -0400 Original-Received: from heytings.org ([95.142.160.155]:33352) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oInVE-0002Rs-F1; Tue, 02 Aug 2022 04:43:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1659429826; bh=2aBEUQtRx0NY/O4ZZQdg5VheVooP89TsgtDPCp/bfGU=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=wWMMAytqjAfdzWU70POUfEmq0LYMtYZUnbo0sK15NOA2aP8QtkfZx6rSOJNt5SXG5 chVeE6MM+SBOx92HImakUzlxaRORC9MTR7M3SGiEfYjcj0HhtwY8U7WGuwMdwZ1aba Vw8qS/Ixk0KOVn3OstpK3pz/kbZ+FUH06PTi3/5gABaAAw9f2u/jvk/w6RQuDPLi9K 6obGOUonzZsAHCBlK0TvgyBGZ45a79she18UdmAtBgeGN0AZkmN+hMzq8hEIfV7EIS 4D3MOJzgKlDUL8/7TMe7kgvVN51cMUAf31BX6Q18TyExMpAicTcwMuxbcAci65L+4Q W2T9ChL5Jw0AA== In-Reply-To: <352C68A4-9CD0-471C-924E-D3858F2561BB@acm.org> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292972 Archived-At: >> Now done on master, and we are back to the statu quo ante with respect >> to byte compilation. > > Thank you -- no remaining objections pertaining to interaction with Lisp > (since there is none). > Note that it would make sense to add some checks in the test suite for the problems you mentioned. When make bootstrap and make check passes (which they did), it seems reasonable for a contributor to conclude that their changeset does not introduce a regression. And perhaps also some clear note in bytecode.c and bytecomp.el that changes to the bytecode are in general not allowed (perhaps there is one already, but I did not see it).