From: Gregory Heytings <gregory@heytings.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: Eli Zaretskii <eliz@gnu.org>,
Philip Kaludercic <philipk@posteo.net>,
silent2600@gmail.com, emacs-devel@gnu.org
Subject: Re: emacs master + org Wrong type argument: number-or-marker-p
Date: Tue, 02 Aug 2022 08:43:45 +0000 [thread overview]
Message-ID: <74ddc877f1a59b576a9f@heytings.org> (raw)
In-Reply-To: <352C68A4-9CD0-471C-924E-D3858F2561BB@acm.org>
>> Now done on master, and we are back to the statu quo ante with respect
>> to byte compilation.
>
> Thank you -- no remaining objections pertaining to interaction with Lisp
> (since there is none).
>
Note that it would make sense to add some checks in the test suite for the
problems you mentioned.
When make bootstrap and make check passes (which they did), it seems
reasonable for a contributor to conclude that their changeset does not
introduce a regression.
And perhaps also some clear note in bytecode.c and bytecomp.el that
changes to the bytecode are in general not allowed (perhaps there is one
already, but I did not see it).
next prev parent reply other threads:[~2022-08-02 8:43 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 13:13 emacs master + org Wrong type argument: number-or-marker-p hx
2022-08-01 13:37 ` Eli Zaretskii
2022-08-01 15:11 ` Philip Kaludercic
2022-08-01 15:52 ` Eli Zaretskii
2022-08-01 16:07 ` Philip Kaludercic
2022-08-01 16:34 ` Visuwesh
2022-08-01 16:11 ` Gregory Heytings
2022-08-01 16:25 ` Eli Zaretskii
2022-08-01 16:34 ` Philip Kaludercic
2022-08-01 16:39 ` Eli Zaretskii
2022-08-01 17:15 ` Mattias Engdegård
2022-08-01 17:24 ` Eli Zaretskii
2022-08-01 17:36 ` Mattias Engdegård
2022-08-01 17:59 ` Eli Zaretskii
2022-08-01 18:06 ` Gregory Heytings
2022-08-01 18:25 ` Eli Zaretskii
2022-08-01 19:14 ` Gregory Heytings
2022-08-01 18:47 ` Mattias Engdegård
2022-08-01 19:16 ` Gregory Heytings
2022-08-01 20:05 ` Alan Mackenzie
2022-08-02 13:46 ` Eli Zaretskii
2022-08-02 18:59 ` Alan Mackenzie
2022-08-02 19:15 ` Eli Zaretskii
2022-08-02 20:28 ` Alan Mackenzie
2022-08-03 1:21 ` Po Lu
2022-08-03 2:38 ` Eli Zaretskii
2022-08-03 4:34 ` Po Lu
2022-08-03 12:02 ` Eli Zaretskii
2022-08-03 12:07 ` Po Lu
2022-08-03 12:34 ` Eli Zaretskii
2022-08-03 13:10 ` Po Lu
2022-08-03 13:36 ` Eli Zaretskii
2022-08-04 1:04 ` Po Lu
2022-08-04 1:09 ` Gregory Heytings
2022-08-04 1:27 ` Po Lu
2022-08-04 6:45 ` Eli Zaretskii
2022-08-03 20:47 ` Stefan Monnier
2022-08-04 5:51 ` Eli Zaretskii
2022-08-04 6:19 ` Po Lu
2022-08-04 7:10 ` Eli Zaretskii
2022-08-04 7:31 ` Po Lu
2022-08-04 7:58 ` Eli Zaretskii
2022-08-04 8:42 ` Po Lu
2022-08-04 9:06 ` Eli Zaretskii
2022-08-04 10:18 ` Alan Mackenzie
2022-08-04 13:18 ` Eli Zaretskii
2022-08-04 16:07 ` Alan Mackenzie
2022-08-04 16:37 ` Eli Zaretskii
2022-08-04 10:26 ` Po Lu
2022-08-04 11:33 ` Werner LEMBERG
2022-08-04 13:10 ` Eli Zaretskii
2022-08-04 21:56 ` Stefan Monnier
2022-08-03 7:21 ` Gregory Heytings
2022-08-03 11:07 ` Po Lu
2022-08-03 12:25 ` Eli Zaretskii
2022-08-03 15:25 ` Gregory Heytings
2022-08-04 1:02 ` Po Lu
2022-08-04 1:08 ` Gregory Heytings
2022-08-04 9:14 ` Stefan Monnier
2022-08-05 3:19 ` Richard Stallman
2022-08-03 8:57 ` Stefan Monnier
2022-08-03 11:05 ` Po Lu
2022-08-03 11:50 ` Eli Zaretskii
2022-08-02 8:25 ` Mattias Engdegård
2022-08-02 8:43 ` Gregory Heytings [this message]
2022-08-02 8:28 ` Stefan Monnier
2022-08-02 8:40 ` Mattias Engdegård
2022-08-01 16:36 ` Gregory Heytings
2022-08-01 16:49 ` Lars Ingebrigtsen
2022-08-01 17:23 ` Andreas Schwab
2022-08-07 15:22 ` Julien Cubizolles
2022-08-01 16:39 ` Andreas Schwab
2022-08-02 16:37 ` Opcode Versioning Was: " Sam Steingold
2022-08-02 22:10 ` Stefan Monnier
2022-08-04 14:59 ` Sam Steingold
2022-08-04 22:11 ` Stefan Monnier
2022-08-02 8:59 ` Po Lu
-- strict thread matches above, loose matches on Subject: below --
2022-08-01 13:45 Gerd Möllmann
2022-08-01 17:36 Gerd Möllmann
2022-08-01 17:58 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74ddc877f1a59b576a9f@heytings.org \
--to=gregory@heytings.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
--cc=philipk@posteo.net \
--cc=silent2600@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).