Re: Unexec dumping results in "Segmentation fault" on Windows Msys2

[Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 727 bytes --]

Thank you. It finally works.

While testing I had another problem related to pdumper stuff getting 
used without being defined. So I wrote a trivial patch for it. But then 
I retested with a clean bootstrap and learned that it normally only 
gives a warning for it:

make[2]: Entering directory '/d/Emacs/configurations/master-unexec/lisp'
   ELC      /d/Emacs/source/repo/lisp/emacs-lisp/bytecomp.elc

In end of data:
D:/Emacs/source/repo/lisp/emacs-lisp/bytecomp.el:5314:39: Warning: the
     function `pdumper-stats' is not known to be defined.

Anyway, I've attached that patch, feel free to apply or not apply it as 
you see fit, since it only removes that one warning, and since unexec is 
deprecated anyway...


[-- Attachment #2: 0001-Don-t-use-pdumper-stats-with-unexec.patch --]
[-- Type: text/plain, Size: 1160 bytes --]

From 9abf8228f55894d62621edc1e5467467e667e1bc Mon Sep 17 00:00:00 2001
From: Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com>
Date: Sat, 1 May 2021 15:27:21 +0300
Subject: [PATCH] Don't use pdumper-stats with unexec

* lisp/emacs-lisp/bytecomp.el (byte-compile-refresh-preloaded): Check if
pdumper-stats is bound before using it.
---
 lisp/emacs-lisp/bytecomp.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 9be54ca4f5..e93cee9924 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -5311,7 +5311,8 @@ byte-compile-refresh-preloaded
   "Reload any Lisp file that was changed since Emacs was dumped.
 Use with caution."
   (let* ((argv0 (car command-line-args))
-         (emacs-file (or (cdr (nth 2 (pdumper-stats)))
+         (emacs-file (or (and (fboundp 'pdumper-stats)
+                              (cdr (nth 2 (pdumper-stats))))
                          (executable-find argv0))))
     (if (not (and emacs-file (file-exists-p emacs-file)))
         (message "Can't find %s to refresh preloaded Lisp files" argv0)
-- 
2.31.1.windows.1