From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: `remove-duplicates' Date: Sun, 10 Jul 2011 09:37:34 -0700 Message-ID: <74402AFBD6F44AF6853153D97D79609E@us.oracle.com> References: <877h7q6ryh.fsf@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1310315892 22846 80.91.229.12 (10 Jul 2011 16:38:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 10 Jul 2011 16:38:12 +0000 (UTC) To: "'David Kastrup'" , Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 10 18:38:07 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qfx1C-00016c-Uz for ged-emacs-devel@m.gmane.org; Sun, 10 Jul 2011 18:38:07 +0200 Original-Received: from localhost ([::1]:33263 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qfx1C-0003gP-7d for ged-emacs-devel@m.gmane.org; Sun, 10 Jul 2011 12:38:06 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:33341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qfx0z-0003gI-Tt for emacs-devel@gnu.org; Sun, 10 Jul 2011 12:37:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qfx0y-0004Sg-Rq for emacs-devel@gnu.org; Sun, 10 Jul 2011 12:37:53 -0400 Original-Received: from acsinet15.oracle.com ([141.146.126.227]:24721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qfx0y-0004SY-N2; Sun, 10 Jul 2011 12:37:52 -0400 Original-Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by acsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p6AGboIJ026221 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 10 Jul 2011 16:37:51 GMT Original-Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p6AGbnlr013959 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 10 Jul 2011 16:37:49 GMT Original-Received: from abhmt114.oracle.com (abhmt114.oracle.com [141.146.116.66]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p6AGbiZ7023163; Sun, 10 Jul 2011 11:37:44 -0500 Original-Received: from dradamslap1 (/10.159.32.168) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 10 Jul 2011 09:37:44 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <877h7q6ryh.fsf@fencepost.gnu.org> Thread-Index: Acw/HE4r4WZelSviQJC6l/JlHyW20AAAlg7w X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090206.4E19D55F.0118:SCFMA922111,ss=1,re=-4.000,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 141.146.126.227 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:141913 Archived-At: One comment wrt adding another Emacs-Lisp function (e.g. `remove-duplicates') that has the same name as an existing Emacs-Lisp function provided by cl.el: Please don't do it; instead, change the name so there is no clash. It's too late to rename the cl.el function by adding a `*' suffix or something, unless you want to break backward compatibility. The problem with having the same name, which already happens in a couple of cases, is that the functions have different behavior (e.g. keywords), or at a minimum different doc. This is a source of confusion, if not errors (which may not be immediately obvious). If you call your new function `remove-dups' or something there will be no problem. But I'm really not trying to say anything particular about what the proper solution is; just pointing to a potential problem that is worth avoiding.