From: "Drew Adams" <drew.adams@oracle.com>
To: "'David Kastrup'" <dak@gnu.org>, <emacs-devel@gnu.org>
Subject: RE: `remove-duplicates'
Date: Sun, 10 Jul 2011 09:37:34 -0700 [thread overview]
Message-ID: <74402AFBD6F44AF6853153D97D79609E@us.oracle.com> (raw)
In-Reply-To: <877h7q6ryh.fsf@fencepost.gnu.org>
One comment wrt adding another Emacs-Lisp function (e.g. `remove-duplicates')
that has the same name as an existing Emacs-Lisp function provided by cl.el:
Please don't do it; instead, change the name so there is no clash.
It's too late to rename the cl.el function by adding a `*' suffix or something,
unless you want to break backward compatibility.
The problem with having the same name, which already happens in a couple of
cases, is that the functions have different behavior (e.g. keywords), or at a
minimum different doc. This is a source of confusion, if not errors (which may
not be immediately obvious).
If you call your new function `remove-dups' or something there will be no
problem. But I'm really not trying to say anything particular about what the
proper solution is; just pointing to a potential problem that is worth avoiding.
next prev parent reply other threads:[~2011-07-10 16:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-10 15:05 `remove-duplicates' Lars Magne Ingebrigtsen
2011-07-10 15:27 ` `remove-duplicates' Juanma Barranquero
2011-07-10 16:06 ` `remove-duplicates' David Kastrup
2011-07-10 16:37 ` Drew Adams [this message]
2011-07-12 3:48 ` `remove-duplicates' Stefan Monnier
2011-07-12 7:22 ` `remove-duplicates' Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74402AFBD6F44AF6853153D97D79609E@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=dak@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).